Re: [evolution-patches] calendar dialog HIG tweaks

[Gary Ekker <gekker novell com>]

> Index: gui/dialogs/task-page.glade
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-page.glade,v
> retrieving revision 1.28
> diff -p -u -r1.28 task-page.glade
> --- gui/dialogs/task-page.glade	22 Jun 2004 22:35:41 -0000	1.28
> +++ gui/dialogs/task-page.glade	13 Jul 2004 20:48:53 -0000
> @@ -287,6 +287,31 @@
>  	      </child>
>  
>  	      <child>
> +		<widget class="GtkLabel" id="label18">
> +		  <property name="visible">True</property>
> +		  <property name="label" translatable="yes">Description:</property>
> +		  <property name="use_underline">False</property>
> +		  <property name="use_markup">False</property>
> +		  <property name="justify">GTK_JUSTIFY_CENTER</property>
> +		  <property name="wrap">False</property>
> +		  <property name="selectable">False</property>
> +		  <property name="xalign">0</property>
> +		  <property name="yalign">0</property>
> +		  <property name="xpad">0</property>
> +		  <property name="ypad">0</property>
> +		  <property name="mnemonic_widget">description</property>
> +		</widget>
> +		<packing>
> +		  <property name="left_attach">0</property>
> +		  <property name="right_attach">1</property>
> +		  <property name="top_attach">3</property>
> +		  <property name="bottom_attach">4</property>
> +		  <property name="x_options">fill</property>
> +		  <property name="y_options">fill</property>
> +		</packing>
> +	      </child>
> +
> +	      <child>
>  		<widget class="GtkScrolledWindow" id="scrolledwindow1">
>  		  <property name="visible">True</property>
>  		  <property name="hscrollbar_policy">GTK_POLICY_NEVER</property>
> @@ -320,32 +345,6 @@
>  		  <property name="top_attach">3</property>
>  		  <property name="bottom_attach">4</property>
>  		  <property name="x_options">fill</property>
> -		  <property name="y_options">fill</property>
> -		</packing>
> -	      </child>
> -
> -	      <child>
> -		<widget class="GtkLabel" id="label18">
> -		  <property name="visible">True</property>
> -		  <property name="label" translatable="yes">Description:</property>
> -		  <property name="use_underline">False</property>
> -		  <property name="use_markup">False</property>
> -		  <property name="justify">GTK_JUSTIFY_CENTER</property>
> -		  <property name="wrap">False</property>
> -		  <property name="selectable">False</property>
> -		  <property name="xalign">0</property>
> -		  <property name="yalign">0</property>
> -		  <property name="xpad">0</property>
> -		  <property name="ypad">0</property>
> -		  <property name="mnemonic_widget">description</property>
> -		</widget>
> -		<packing>
> -		  <property name="left_attach">0</property>
> -		  <property name="right_attach">1</property>
> -		  <property name="top_attach">3</property>
> -		  <property name="bottom_attach">4</property>
> -		  <property name="x_options">fill</property>
> -		  <property name="y_options">fill</property>
>  		</packing>
>  	      </child>
>  	    </widget>
> @@ -358,7 +357,7 @@
>  	</widget>
>  	<packing>
>  	  <property name="padding">0</property>
> -	  <property name="expand">False</property>
> +	  <property name="expand">True</property>
>  	  <property name="fill">True</property>
Shouldn't expand and fill both be set to False here so that the behavior
in the task editor is consistent with that of the event editor?

There seems to be a big block of padding at the bottom of the editor if
these are set to True. Just a thought, since I have no real say in the
matter :) This has been bugging me for a while now, so I'm grateful for
the patch.

>  	</packing>
>        </child>