GNOME.org
 

Re: [evolution-patches] calendar dialog HIG tweaks

It would be great to see a patch for the task editor as well :)

On Tue, 2004-07-13 at 15:56 -0400, William Jon McCann wrote:
> Hi,
> 
> This patch removes separators from two dialogs and makes the Description 
> text box in the event page expand with the window.
> 
> Without this the description box stays small (like 2 lines) no matter 
> what the window size.
> 
> Ok to commit?
> 
> Jon
> Plain text document attachment (cal-hig.patch)
> ? gui/goto-dialog.gladep
> ? gui/dialogs/event-page.gladep
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
> retrieving revision 1.2444
> diff -p -u -r1.2444 ChangeLog
> --- ChangeLog	13 Jul 2004 11:07:19 -0000	1.2444
> +++ ChangeLog	13 Jul 2004 19:54:48 -0000
> @@ -1,3 +1,10 @@
> +2004-07-13  William Jon McCann  <mccann jhu edu>
> +
> +	* gui/dialogs/event-page.glade: Make Description box expand
> +	with window.
> +	* gui/goto-dialog.glade:
> +	* gui/dialogs/new-calendar.glade: Remove separator per HIG.
> +
>  2004-07-08  Radek Doulik  <rodo ximian com>
>  
>  	* gui/e-cal-model.c (e_cal_model_date_value_to_string): as below
> Index: gui/goto-dialog.glade
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/gui/goto-dialog.glade,v
> retrieving revision 1.13
> diff -p -u -r1.13 goto-dialog.glade
> --- gui/goto-dialog.glade	29 Mar 2004 15:24:00 -0000	1.13
> +++ gui/goto-dialog.glade	13 Jul 2004 19:54:48 -0000
> @@ -10,7 +10,7 @@
>    <property name="modal">False</property>
>    <property name="resizable">True</property>
>    <property name="destroy_with_parent">False</property>
> -  <property name="has_separator">True</property>
> +  <property name="has_separator">False</property>
>  
>    <child internal-child="vbox">
>      <widget class="GtkVBox" id="dialog-vbox1">
> Index: gui/dialogs/event-page.glade
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/event-page.glade,v
> retrieving revision 1.20
> diff -p -u -r1.20 event-page.glade
> --- gui/dialogs/event-page.glade	23 Jun 2004 00:18:02 -0000	1.20
> +++ gui/dialogs/event-page.glade	13 Jul 2004 19:54:48 -0000
> @@ -173,44 +173,6 @@
>  	      </child>
>  
>  	      <child>
> -		<widget class="GtkScrolledWindow" id="scrolledwindow12">
> -		  <property name="visible">True</property>
> -		  <property name="hscrollbar_policy">GTK_POLICY_NEVER</property>
> -		  <property name="vscrollbar_policy">GTK_POLICY_AUTOMATIC</property>
> -		  <property name="shadow_type">GTK_SHADOW_IN</property>
> -		  <property name="window_placement">GTK_CORNER_TOP_LEFT</property>
> -
> -		  <child>
> -		    <widget class="GtkTextView" id="description">
> -		      <property name="visible">True</property>
> -		      <property name="can_focus">True</property>
> -		      <property name="editable">True</property>
> -		      <property name="overwrite">False</property>
> -		      <property name="accepts_tab">True</property>
> -		      <property name="justification">GTK_JUSTIFY_LEFT</property>
> -		      <property name="wrap_mode">GTK_WRAP_WORD</property>
> -		      <property name="cursor_visible">True</property>
> -		      <property name="pixels_above_lines">0</property>
> -		      <property name="pixels_below_lines">0</property>
> -		      <property name="pixels_inside_wrap">0</property>
> -		      <property name="left_margin">0</property>
> -		      <property name="right_margin">0</property>
> -		      <property name="indent">0</property>
> -		      <property name="text" translatable="yes"></property>
> -		    </widget>
> -		  </child>
> -		</widget>
> -		<packing>
> -		  <property name="left_attach">1</property>
> -		  <property name="right_attach">2</property>
> -		  <property name="top_attach">4</property>
> -		  <property name="bottom_attach">5</property>
> -		  <property name="x_options">fill</property>
> -		  <property name="y_options">fill</property>
> -		</packing>
> -	      </child>
> -
> -	      <child>
>  		<widget class="GtkLabel" id="label69">
>  		  <property name="visible">True</property>
>  		  <property name="label" translatable="yes">Classi_fication:</property>
> @@ -296,7 +258,7 @@
>  		      <property name="yalign">0.5</property>
>  		      <property name="xpad">0</property>
>  		      <property name="ypad">0</property>
> -		  <property name="mnemonic_widget">source</property>
> +		      <property name="mnemonic_widget">source</property>
>  		    </widget>
>  		    <packing>
>  		      <property name="padding">0</property>
> @@ -371,6 +333,43 @@
>  	      </child>
>  
>  	      <child>
> +		<widget class="GtkScrolledWindow" id="scrolledwindow12">
> +		  <property name="visible">True</property>
> +		  <property name="hscrollbar_policy">GTK_POLICY_NEVER</property>
> +		  <property name="vscrollbar_policy">GTK_POLICY_AUTOMATIC</property>
> +		  <property name="shadow_type">GTK_SHADOW_IN</property>
> +		  <property name="window_placement">GTK_CORNER_TOP_LEFT</property>
> +
> +		  <child>
> +		    <widget class="GtkTextView" id="description">
> +		      <property name="visible">True</property>
> +		      <property name="can_focus">True</property>
> +		      <property name="editable">True</property>
> +		      <property name="overwrite">False</property>
> +		      <property name="accepts_tab">True</property>
> +		      <property name="justification">GTK_JUSTIFY_LEFT</property>
> +		      <property name="wrap_mode">GTK_WRAP_WORD</property>
> +		      <property name="cursor_visible">True</property>
> +		      <property name="pixels_above_lines">0</property>
> +		      <property name="pixels_below_lines">0</property>
> +		      <property name="pixels_inside_wrap">0</property>
> +		      <property name="left_margin">0</property>
> +		      <property name="right_margin">0</property>
> +		      <property name="indent">0</property>
> +		      <property name="text" translatable="yes"></property>
> +		    </widget>
> +		  </child>
> +		</widget>
> +		<packing>
> +		  <property name="left_attach">1</property>
> +		  <property name="right_attach">2</property>
> +		  <property name="top_attach">4</property>
> +		  <property name="bottom_attach">5</property>
> +		  <property name="x_options">fill</property>
> +		</packing>
> +	      </child>
> +
> +	      <child>
>  		<widget class="GtkLabel" id="label68">
>  		  <property name="visible">True</property>
>  		  <property name="label" translatable="yes">_Description:</property>
> @@ -404,8 +403,8 @@
>  	</widget>
>  	<packing>
>  	  <property name="padding">0</property>
> -	  <property name="expand">False</property>
> -	  <property name="fill">False</property>
> +	  <property name="expand">True</property>
> +	  <property name="fill">True</property>
>  	</packing>
>        </child>
>  
> Index: gui/dialogs/new-calendar.glade
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/new-calendar.glade,v
> retrieving revision 1.5
> diff -p -u -r1.5 new-calendar.glade
> --- gui/dialogs/new-calendar.glade	12 Jan 2004 21:19:09 -0000	1.5
> +++ gui/dialogs/new-calendar.glade	13 Jul 2004 19:54:48 -0000
> @@ -12,7 +12,7 @@
>    <property name="modal">False</property>
>    <property name="resizable">False</property>
>    <property name="destroy_with_parent">False</property>
> -  <property name="has_separator">True</property>
> +  <property name="has_separator">False</property>
>  
>    <child internal-child="vbox">
>      <widget class="GtkVBox" id="dialog-vbox1">
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]