Re: [evolution-patches] Patch for adding limited support for Recurrences plus a few bug fixes.
- From: Harish Krishnaswamy <kharish novell com>
- To: Rodrigo Moya <rodrigo novell com>
- Cc: Evolution Patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] Patch for adding limited support for Recurrences plus a few bug fixes.
- Date: Tue, 13 Jul 2004 18:08:17 +0530
hi,
Thanks for the review.
> > + // change the first . to a @ to bypass a server bug
> >
> use better /* .. */ for comments, since this will fail with compilers
> other than gcc.
This bug has been fixed in the server side.. So i am removing the
changes in this function, anyway.
> > + x_name = icalproperty_get_x_name (prop);
> > + x_val = icalproperty_get_x (prop);
> > + if (!strcmp (x_name, "X-GWRECORDID")) {
> >
> hmm, IIRC, wasn't this called X-GROUPWISE-something?
As mentioned in the ChangeLog, the server calls this property
X-GWRECORDID while sending the itip messages. I have renamed in the
eds code for consistency.
Is it fine to commit then ?
Thanks,
harish
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]