Re: [evolution-patches] Patch for adding limited support for Recurrences plus a few bug fixes.

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2004-07-12 at 17:57 +0530, Harish Krishnaswamy wrote:
> hi,
> 
> The following is a patch for adding a limited support for recurring
> calendar items in the GW calendar and fixes for 59471, 56853 and 60926.
> Sorry not to have split them into smaller chunks :( .  These changes
> work only with GW server builds later than 9th of July 04. and i wanted
> to keep the apply/retract options simple...
> 

> +			// change the first . to a @ to bypass a server bug
>
use better /* .. */ for comments, since this will fail with compilers
other than gcc.

> +						 ICAL_X_PROPERTY);
> +	while (prop) {
> +		const char *x_name, *x_val;
> +
> +		x_name = icalproperty_get_x_name (prop);
> +		x_val = icalproperty_get_x (prop);
> +		if (!strcmp (x_name, "X-GWRECORDID")) {
>
hmm, IIRC, wasn't this called X-GROUPWISE-something?

> @@ -347,7 +353,7 @@ e_gw_item_to_cal_component (EGwItem *ite
>  		icalproperty *icalprop;
>  
>  		icalprop = icalproperty_new_x (description);
> -		icalproperty_set_x_name (icalprop, "X-EVOLUTION-GROUPWISE-ID");
> +		icalproperty_set_x_name (icalprop, "X-GWRECORDID");
>
oh, why are you changing it?

the rest looks ok to me.

cheers