Re: [evolution-patches] mail HIG patch

[Not Zed <notzed ximian com>]

On Wed, 2004-01-07 at 14:42 -0500, William Jon McCann wrote:

-                               frame = gtk_frame_new (entries[i].text);
-                               gtk_container_set_border_width
(GTK_CONTAINER (frame), 3);
-                               gtk_table_attach (main_table, frame, 0,
2,
+                               vbox = gtk_vbox_new (FALSE, 6);
+
+                               gtk_table_attach (main_table, vbox, 0,
2,
                                                  rows, rows + 1,
                                                  GTK_EXPAND | GTK_FILL,
0, 0, 0);
+                               markup = g_strdup_printf ("<b>%s</b>",
entries[i].text);
+                               label = gtk_label_new (markup);
+                               gtk_label_set_use_markup (GTK_LABEL
(label), TRUE);
+                               gtk_misc_set_alignment (GTK_MISC
(label), 0.0, 0.5);
+                               gtk_box_pack_start (GTK_BOX (vbox),
label, FALSE, FALSE, 0);
+                               gtk_widget_show (label);
+                               g_free (markup);
+
+                               hbox = gtk_hbox_new (FALSE, 0);
+                               gtk_box_pack_start (GTK_BOX (vbox),
hbox, FALSE, FALSE, 0);
+                               gtk_widget_show (hbox);
+                               label = gtk_label_new ("    ");
+                               gtk_box_pack_start (GTK_BOX (hbox),
label, FALSE, FALSE, 0);
+                               gtk_widget_show (label);
 

Why do you do this here, but elsewhere you just set the frame to no
border and embolden the label?  Seems pretty complex, especially the "
" label???

And why do you do the same in the glade file?  Thats a huge semantic
difference to the code.