Re: [evolution-patches] Patch for 52378: all new mail marked as spam

[Frank Solensky <frank solensky org>]

On Sun, 2004-01-04 at 22:18, Not Zed wrote:
> > -       retval = pipe_to_sa (NULL, "From test 127 0 0 1", 3, sac_args) == 0;
> > +       retval = pipe_to_sa (NULL, "From test 127 0 0 1", 1, sac_args)
> 
> Shouldn't this remain 3?

Ah, yes.  The only thing this affects is what gets printed in a debug
statement, but yes, it should be 3.

> 
> Otherwise i guess the patch is ok.  To be honest, pipe_to_sa seems a
> pretty odd api, it is only ever passed 1 thing that changes, and
> passing in "/bin/sh" "-c" every time, seems redundant, maybe the whole
> argc/argv thing can be removed, and just pass in the command to run as
> a simple string.

The "/bin/sh","-c" elements, I agree, don't seem to be needed but I'm
wondering how this is working to begin with.  I wouldn't expect that
execvp() would be splitting the string into another argv array -- it
looks more like the child's argv[0] has spaces embedded.  Well, if it's
working, it's working..