Re: [evolution-patches] Patch for 52378: all new mail marked as spam

[Not Zed <notzed ximian com>]

looks reasonable at first glance,  but please submit following the guidelines in the HACKING file.  Particularly, it must include a ChangeLog and should be in unified diff format.

On Sat, 2004-01-03 at 10:17 -0500, Frank Solensky wrote:
> The following patch fixes the above bug.  The problem was that the
> command vector needs to include a null list terminator; the one that's
> at offset 2 is overwritten with the actual command line.
> -----------
> diff -r1.4 em-junk-filter.c
> 169c169
> <       static gchar *sac_args [3] = {
> ---
> >       static gchar *sac_args [4] = {
> 171a172
> >               NULL,
> 179c180
> <       retval = pipe_to_sa (NULL, "From test 127 0 0 1", 3, sac_args)
> == 0;
> ---
> >       retval = pipe_to_sa (NULL, "From test 127 0 0 1", 1, sac_args)
> == 0;
> 189c190
> <       static gchar *args [3] = {
> ---
> >       static gchar *args [4] = {
> 192c193,194
> <               "spamassassin --version"
> ---
> >               "spamassassin --version",
> >               NULL
> 216c218
> <                       static gchar *sad_args [3] = {
> ---
> >                       static gchar *sad_args [4] = {
> 218a221
> >                               NULL,
> 261c264
> <       static gchar *args [3] = {
> ---
> >       static gchar *args [4] = {
> 263a267
> >               NULL,
> 269d272
> <
> 296c299
> <       static gchar *args [3] = {
> ---
> >       static gchar *args [4] = {
> 303c306,307
> <               " --local"             /* local only */
> ---
> >               " --local",            /* local only */
> >               NULL
> 315c319
> <       static gchar *args [3] = {
> ---
> >       static gchar *args [4] = {
> 322c326,327
> <               " --local"             /* local only */
> ---
> >               " --local",            /* local only */
> >               NULL
> 334c339
> <       static gchar *args [3] = {
> ---
> >       static gchar *args [4] = {
> 339c344,345
> <               " --local"             /* local only */
> ---
> >               " --local",            /* local only */
> >               NULL
>
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches