Re: [evolution-patches] address book patch to fix #52765

[sh <hao sheng sun com>]

Hi ,chris
Thank you for your  review my patch and discuss it.
But I think we can have two ways to close those windows.
This will make the users feel more convenient.
I think that all the windows in evolution are the same to the users.
So users may be used to close those windows in the same way.
All these is my opinion. You  can discuss it and send feedback to me.

BTW, I have sent you the simiplified patch just for bug 52765.
If you have approved this oneline patch,  I will check it in soon .
Attach is the simiplified patch just for bug 52765.
Would you like to spend a little time to review it?

Best regards



Chris Toshok wrote:

> Having it close the composer is arguably a bad thing too, though,
> right?  we have ctrl-w bindings in both those windows, and they aren't
> really "dialogs"..
>
> Chris
>
> On Tue, 2004-02-17 at 16:47, Not Zed wrote:
>  
>
> > It closes the mail composer ... consistency ...
> >
> > On Tue, 2004-02-17 at 12:36 -0800, Chris Toshok wrote:
> >
> >    
> >
> > > do we really need/want ESC closing the contact editor?
> > >
> > > ctrl-w already works to close the window.
> > >
> > >      
> >    

Index: gui/contact-editor/e-contact-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/contact-editor/e-contact-editor.c,v
retrieving revision 1.165
diff -u -r1.165 e-contact-editor.c
--- gui/contact-editor/e-contact-editor.c	30 Jan 2004 22:52:38 -0000	1.165
+++ gui/contact-editor/e-contact-editor.c	17 Feb 2004 03:07:34 -0000
@@ -1729,7 +1729,7 @@
 					    "to delete this contact?"));
 
 	gtk_dialog_add_buttons (GTK_DIALOG (dialog),
-				GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT,
+				GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
 				GTK_STOCK_DELETE, GTK_RESPONSE_ACCEPT,
 				NULL);