Re: [evolution-patches] Always capitalize "On This Computer"

[Christian Neumair <chris gnome-de org>]

On Wed, 2004-02-11 at 15:03 -0500, Rodney Dawes wrote:

> On Wed, 2004-02-11 at 20:21 +0100, Christian Neumair wrote:
> > Currently, "On this computer" and "On This Computer" are used
> > inconsistently for tree view categories. This patch should unify those
> > strings.
> 
> Shouldn't be "On this Computer" if it's going to mention being on
> something at all? In English, modifiers amidst titles, do not get
> capitalization, only those that begin the title do. And this is
> clearly the title of a group in the tree. Section 8.3 specifies
> that it should have "Header" capitalization. Therefore, it should
> be "this" not "This", as it is not "This Computer", but "On this
> Computer".

Looks like you're right. Patch attached.

regs,
 Chris

Index: addressbook/gui/component/addressbook-migrate.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/component/addressbook-migrate.c,v
retrieving revision 1.15
diff -u -r1.15 addressbook-migrate.c
--- addressbook/gui/component/addressbook-migrate.c	8 Feb 2004 19:16:31 -0000	1.15
+++ addressbook/gui/component/addressbook-migrate.c	11 Feb 2004 20:10:12 -0000
@@ -403,7 +403,7 @@
 	}
 	else {
 		/* create the local source group */
-		group = e_source_group_new (_("On This Computer"), base_uri_proto);
+		group = e_source_group_new (_("On this Computer"), base_uri_proto);
 		e_source_list_add_group (context->source_list, group, -1);
 
 		*on_this_computer = group;
Index: calendar/gui/migration.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/migration.c,v
retrieving revision 1.14
diff -u -r1.14 migration.c
--- calendar/gui/migration.c	29 Jan 2004 16:31:13 -0000	1.14
+++ calendar/gui/migration.c	11 Feb 2004 20:10:13 -0000
@@ -422,7 +422,7 @@
 		}
 	} else {
 		/* create the local source group */
-		group = e_source_group_new (_("On This Computer"), base_uri_proto);
+		group = e_source_group_new (_("On this Computer"), base_uri_proto);
 		e_source_list_add_group (source_list, group, -1);
 
 		*on_this_computer = group;
@@ -499,7 +499,7 @@
 		}
 	} else {
 		/* create the local source group */
-		group = e_source_group_new (_("On This Computer"), base_uri_proto);
+		group = e_source_group_new (_("On this Computer"), base_uri_proto);
 		e_source_list_add_group (source_list, group, -1);
 
 		*on_this_computer = group;
Index: mail/em-folder-tree-model.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-folder-tree-model.c,v
retrieving revision 1.37
diff -u -r1.37 em-folder-tree-model.c
--- mail/em-folder-tree-model.c	11 Feb 2004 19:34:48 -0000	1.37
+++ mail/em-folder-tree-model.c	11 Feb 2004 20:10:13 -0000
@@ -156,10 +156,10 @@
 	gtk_tree_model_get (model, b, COL_STRING_DISPLAY_NAME, &bname, -1);
 	
 	if (is_store) {
-		/* On This Computer is always first and VFolders is always last */
-		if (!strcmp (aname, _("On This Computer")))
+		/* On this Computer is always first and VFolders is always last */
+		if (!strcmp (aname, _("On this Computer")))
 			return -1;
-		if (!strcmp (bname, _("On This Computer")))
+		if (!strcmp (bname, _("On this Computer")))
 			return 1;
 		if (!strcmp (aname, _("VFolders")))
 			return 1;
Index: mail/mail-component.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-component.c,v
retrieving revision 1.54
diff -u -r1.54 mail-component.c
--- mail/mail-component.c	11 Feb 2004 19:34:48 -0000	1.54
+++ mail/mail-component.c	11 Feb 2004 20:10:14 -0000
@@ -170,7 +170,7 @@
 
 	g_object_ref(mc);
 	camel_object_ref(p->local_store);
-	mail_async_event_emit(p->async_event, MAIL_ASYNC_GUI, (MailAsyncFunc)mc_add_store, p->local_store, _("On This Computer"), mc);
+	mail_async_event_emit(p->async_event, MAIL_ASYNC_GUI, (MailAsyncFunc)mc_add_store, p->local_store, _("On this Computer"), mc);
 
 	return;
 fail: