Re: [evolution-patches] Save-calendar plugin. saving to comma separated files

[Rodrigo Moya <rodrigo novell com>]

On Wed, 2004-12-01 at 19:50 +0100, Philip Van Hoof wrote:
> On Wed, 2004-12-01 at 19:03 +0100, Rodrigo Moya wrote:
> 
> > Apart from that, there are a lot of things to change to match the coding standards,
> > mainly putting the { char on the same line as the statement, instead of in its own
> > line.
> 
> Hi Rodrigo (and the others in CC),
> 
> I'll start using a diff-filenameing-sheme to avoid confusion
> 
> 	save-calendar.c.##.diff cvs
> 
ok, this time it looks better, I've committed it to HEAd with some
formatting changes and the below mentioned stuff:

> +                       e_cal_component_get_dtstart (comp, &temp_dt);
> +                       line = add_time_to_csv (line,
> &temp_dt?temp_dt.value:NULL, config);
> +                       if (&temp_dt) e_cal_component_free_datetime
> (&temp_dt);
> +
> +                       e_cal_component_get_dtend (comp, &temp_dt);
> +                       line = add_time_to_csv (line,
> &temp_dt?temp_dt.value:NULL, config);
> +                       if (&temp_dt) e_cal_component_free_datetime
> (&temp_dt);
> 
here you should not check for &temp_dt, which will be always non-NULL,
but for temp_dt.value.

Apart from that, this patch is missing the changes in the org...eplug
file, isn't it? Could you send a new patch for that part only?

-- 
Rodrigo Moya <rodrigo novell com>