Re: [evolution-patches] [dsevilla ditec um es: Patch for #46229]

[Diego Sevilla Ruiz <dsevilla ditec um es>]

Hi, Rodney:

El jue, 02-12-2004 a las 16:46 -0500, Rodney Dawes escribió:
> A few things...
> 
> Your patch includes several changes to the ChangeLog which apparently
> seem to change the spacing of unrelated lines. This shouldn't be there.
> 

OK, fixed. Sorry for that.

> Your changes to the glade file seem overly extensive, in that a lot of
> properties are being added, that don't belong there. Perhaps you have
> and old version of glade which breaks in this respect.
> 

That's strange. I have debian's glade-gnome-2:

glade-gnome-2  2.6.5-3        GTK+ 2 User Interface Builder

What should I use?

> The "Show filters for mail:" label shouldn't be bold, and should use
> verb sentence capitalization, so filters and mail should be lowercase.
> 

OK, sorry again, that's also fixed.

> Other than these issues though, I think it looks ok. Please re-submit
> with these fixes.
> 

Here it is.

	Thanks!
	diego

-- 
Diego Sevilla Ruiz <dsevilla ditec um es>

? diff
? filter.gladep
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/filter/ChangeLog,v
retrieving revision 1.418
diff -u -r1.418 ChangeLog
--- ChangeLog	1 Dec 2004 05:59:07 -0000	1.418
+++ ChangeLog	3 Dec 2004 00:52:03 -0000
@@ -1,3 +1,8 @@
+2004-12-02  Diego Sevilla Ruiz  <dsevilla dsevilla>
+
+	* filter.glade:
+	* filter-rule.c: Applied patches proposed by #46229.
+
 2004-11-29  Mengjie Yu  <meng-jie yu sun com>
 
 	* filter-rule.c: (get_widget):add mnemonic widget in search box.
Index: filter-rule.c
===================================================================
RCS file: /cvs/gnome/evolution/filter/filter-rule.c,v
retrieving revision 1.65
diff -u -r1.65 filter-rule.c
--- filter-rule.c	1 Dec 2004 05:59:07 -0000	1.65
+++ filter-rule.c	3 Dec 2004 00:52:04 -0000
@@ -972,6 +972,6 @@
 #ifdef FOR_TRANSLATIONS_ONLY
 
 static char *list[] = {
-  N_("incoming"), N_("outgoing")
+  N_("Incoming"), N_("Outgoing")
 };
 #endif
Index: filter.glade
===================================================================
RCS file: /cvs/gnome/evolution/filter/filter.glade,v
retrieving revision 1.23
diff -u -r1.23 filter.glade
--- filter.glade	17 Jun 2004 07:34:07 -0000	1.23
+++ filter.glade	3 Dec 2004 00:52:04 -0000
@@ -21,6 +21,27 @@
       <property name="spacing">6</property>
 
       <child>
+        <widget class="GtkLabel" id="label17">
+	  <property name="visible">True</property>
+	  <property name="label" translatable="yes">Show filter for mail:</property>
+	  <property name="use_underline">False</property>
+	  <property name="use_markup">False</property>
+	  <property name="justify">GTK_JUSTIFY_LEFT</property>
+	  <property name="wrap">False</property>
+	  <property name="selectable">False</property>
+	  <property name="xalign">0</property>
+	  <property name="yalign">0.5</property>
+	  <property name="xpad">0</property>
+	  <property name="ypad">0</property>
+	</widget>
+	<packing>
+	  <property name="padding">0</property>
+	  <property name="expand">False</property>
+	  <property name="fill">False</property>
+	</packing>
+      </child>
+
+      <child>
 	<widget class="GtkOptionMenu" id="filter_source">
 	  <property name="can_focus">True</property>
 	  <property name="history">0</property>