Re: [evolution-patches] [dsevilla ditec um es: Patch for #46229]

[Rodney Dawes <dobey novell com>]

A few things...

Your patch includes several changes to the ChangeLog which apparently
seem to change the spacing of unrelated lines. This shouldn't be there.

Your changes to the glade file seem overly extensive, in that a lot of
properties are being added, that don't belong there. Perhaps you have
and old version of glade which breaks in this respect.

The "Show filters for mail:" label shouldn't be bold, and should use
verb sentence capitalization, so filters and mail should be lowercase.

Other than these issues though, I think it looks ok. Please re-submit
with these fixes.

Thanks.
-- dobey


On Wed, 2004-11-24 at 22:52 +0100, Diego Sevilla Ruiz wrote:
> Hi:
> 
> 	I think this one I sent some time ago got unapproved because I
> was not subscribed.
> 
> 	Please, review it.
> 
> 	Best regards,
> 	diego
>