Re: [Fwd: [evolution-patches] fix for bug #62665]



Le mardi 31 août 2004 à 13:23 -0400, Jeffrey Stedfast a écrit :
> On Tue, 2004-08-31 at 17:33 +0100, Mark McLoughlin wrote:
> > On Tue, 2004-08-31 at 17:10, Jeffrey Stedfast wrote:
> > > I've tested it - it wouldn't be up for review if it hadn't been tested.
> > 
> > 	Murray was referring to:
> > 
> >   - Telling us why you think the change should not wait for the next
> >     development phase.
> 
> I think that should be obvious. the wrong folder gets deleted.

Adding a small summary for bug when sending the patch is nice for us,
since we get a lot of patch to review and it is easier to have all infos
in the mail than having to dig inside bugzilla.

> it's also marked for 2.0.0 by JPR, not by me. there's been fairly strict
> 2.0.0 milestoning by JPR for all the evo bugs.

Please, remember that not all release-team members are aware of the
review procedure used by the evolution team. Same apply for the bug
milestoning for evolution.

> >   - If you want to break the Hard Code Freeze, then please persuade
> >     us that the patch is very safe or has been well tested.
> 
> I wouldn't be sending in patches that I didn't feel were correct and
> well tested, especially not this late in the release cycle. it's also a
> pretty trivial patch :)
> 
> oh, and it's also already been approved by NotZed (the other Mail
> maintainer)

Patch is ok for me.

1 RT approval of 2.

-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]