Re: [evolution-patches] patch for the bug #64398 [calendar]




umm, you should not rely on an assertion to save you from a case which could happen in normal code running.

if it isn't a code error, but a possible run-time case, it should just be a normal if() statement.  If it is a code error, the source of the error should be fixed ideally.

i.e. the code shouldn't crash if the assertions aren't present and there are no bugs present.

On Tue, 2004-08-31 at 16:54 +0200, Rodrigo Moya wrote:
On Tue, 2004-08-31 at 20:41 +0530, chenthill wrote:
> Hi,
>   The crash in the getdeltas happened when the backend has died while
> the E-D-S is still running. In this case cbgw is NULL and getDeltas
> crashed. Have attached a patch to avoid the crash.
> 

looks good
--
Michael Zucchi <notzed ximian com>
"born to die, live to work, it's all downhill from here"
Novell's Evolution and Free Software Developer


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]