[evolution-patches] patch for the bug #64398 [calendar]



Hi,
  The crash in the getdeltas happened when the backend has died while
the E-D-S is still running. In this case cbgw is NULL and getDeltas
crashed. Have attached a patch to avoid the crash.

thanks, chenthill.


Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/calendar/ChangeLog,v
retrieving revision 1.324
diff -u -p -r1.324 ChangeLog
--- ChangeLog	27 Aug 2004 18:09:58 -0000	1.324
+++ ChangeLog	31 Aug 2004 14:27:34 -0000
@@ -1,3 +1,10 @@
+2004-08-31  Chenthill Palanisamy <pchenthill novell com>
+	
+	Fixes #64398
+	* backends/groupwise/e-cal-backend-groupwise.c
+	(get_deltas): Return FALSE if cbgw is NULL so that
+	it will not be called again.
+
 2004-08-27  Rodrigo Moya <rodrigo novell com>
 
 	* libedata-cal/e-cal-backend-sexp.c (func_has_alarms_in_range): new
Index: backends/groupwise/e-cal-backend-groupwise.c
===================================================================
RCS file: /cvs/gnome/evolution-data-
server/calendar/backends/groupwise/e-cal-backend-groupwise.c,v
retrieving revision 1.89
diff -u -p -r1.89 e-cal-backend-groupwise.c
--- backends/groupwise/e-cal-backend-groupwise.c	25 Aug 2004 15:12:12
-0000	1.89
+++ backends/groupwise/e-cal-backend-groupwise.c	31 Aug 2004 14:27:34
-0000
@@ -180,6 +180,9 @@ get_deltas (gpointer handle)
 	GSList *deletes = NULL, *updates = NULL, *adds = NULL, *l;
         
 	cbgw = (ECalBackendGroupwise *) handle;
+
+	g_return_val_if_fail (cbgw != NULL, FALSE);
+
  	cnc = cbgw->priv->cnc; 
  	cache = cbgw->priv->cache; 
 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]