[evolution-patches] Re: Patch for the bug ##63778

[shenghao <hao sheng sun com>]

hi , Chris

Can the patch for #63778 be commited into the trunk of the ximian?

and when we will past the hard string freeze date?

Thank you for your help!

best regards
hao.sheng



Chris Toshok wrote:

> technically the patch looks fine.  This breaks string freeze though.  is
> this a problem, anyone - are we past some hard string freeze date?
>
> Chris
>
> On Tue, 2004-08-24 at 17:18 +0800, shenghao wrote:
>  
>
> > hi, Chris
> >
> > Attach is the patch to fix the bug #63778 on http://bugzilla.ximian.com.
> > Please Would you like to spend a little time to review it, please?
> >
> > Best regards
> > hao.sheng
> >
> >
> > !DSPAM:412b091539131613015313!
> > Email message/mailbox attachment (Attached Message)
> > On Tue, 2004-08-24 at 17:18 +0800, shenghao wrote:
> >    

Return-path: <root autoracing PRC sun com>
Received: from conversion-daemon.eri-mail1.prc.sun.com by eri-mail1.prc.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003))
 id <0I2Y009011PB4T eri-mail1 prc sun com>
 (original mail from root autoracing PRC sun com)
 for hs150204 eri-mail1 PRC Sun COM; Tue, 24 Aug 2004 17:16:05 +0800 (CST)
Received: from sunbj.PRC.Sun.COM (sunbj.PRC.Sun.COM [129.158.166.21])
 by eri-mail1.prc.sun.com
 (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003))
 with ESMTP id <0I2Y00MB71QT5Z eri-mail1 prc sun com> for
 hs150204 eri-mail1 PRC Sun COM; Tue, 24 Aug 2004 17:16:05 +0800 (CST)
Received: from sunmail3.sfbay.sun.com
 (sunmail3.SFBay.Sun.COM [129.149.247.180])	by sunbj.PRC.Sun.COM
 (8.12.10+Sun/8.12.10/ENSMAIL,v2.2) with ESMTP id i7O9G4Mm019644	for
 <hao sheng prc sun com>; Tue, 24 Aug 2004 17:16:04 +0800 (CST)
Received: from autoracing.prc.sun.com
 (autoracing.PRC.Sun.COM [129.158.217.111])	by sunmail3.sfbay.sun.com
 (8.11.7p1+Sun/8.11.7/ENSMAIL,v2.2) with ESMTP id i7O9G1W08043	for
 <hao sheng sun com>; Tue, 24 Aug 2004 02:16:01 -0700 (PDT)
Received: by autoracing.prc.sun.com (Postfix, from userid 0)	id 614718B49; Tue,
 24 Aug 2004 17:13:38 +0800 (CST)
Date: Tue, 24 Aug 2004 17:13:38 +0800 (CST)
From: root autoracing PRC sun com (root)
To: Hao Sheng Sun COM
Message-id: <20040824091338 614718B49 autoracing prc sun com>
Content-type: TEXT/PLAIN
Original-recipient: rfc822;hs150204 eri-mail1 PRC Sun COM

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1816
diff -u -r1.1816 ChangeLog
--- ChangeLog	21 Aug 2004 21:53:41 -0000	1.1816
+++ ChangeLog	24 Aug 2004 09:15:29 -0000
@@ -1,3 +1,12 @@
+2004-08-24 Hao Sheng <hao sheng sun com>
+	
+	Fixes bug #63778
+
+	* gui/component/addressbook-config.c:
+	(setup_searching_tab): add atk object name to the "timeout-scale"
+	widget, so it can be UI Grab.
+				
+
 2004-08-20  Chris Toshok  <toshok ximian com>
 
 	* gui/component/component-factory.c (factory): remove the dead
Index: gui/component/addressbook-config.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/component/addressbook-config.c,v
retrieving revision 1.87
diff -u -r1.87 addressbook-config.c
--- gui/component/addressbook-config.c	2 Aug 2004 18:03:04 -0000	1.87
+++ gui/component/addressbook-config.c	24 Aug 2004 09:15:29 -0000
@@ -782,7 +782,8 @@
 {
 	GtkWidget *menu;
 	GtkWidget *rootdn_button;
-
+	AtkObject * a11y;
+	
 	dialog->searching_modify_func = modify_func;
 
 
@@ -798,7 +799,11 @@
 	gtk_container_foreach (GTK_CONTAINER (menu), (GtkCallback)add_scope_activate_cb, dialog);
 
 	dialog->timeout_scale = glade_xml_get_widget (dialog->gui, "timeout-scale");
-	
+	a11y = gtk_widget_get_accessible (dialog->timeout_scale);
+	if (a11y != NULL) {
+		atk_object_set_name (a11y, _("Timeout scale"));
+	}
+		
 	if (modify_func)
 		g_signal_connect (GTK_RANGE(dialog->timeout_scale)->adjustment,
 				  "value_changed",