Re: [evolution-patches] Ask user to make evolution default mail app bug #127526 (Mail)

[Not Zed <notzed ximian com>]

Sorry for not getting back to you, since we have a 2.0 release imminent, future-applying patches are a low priority right now.

+       if (mailapp && !strcmp (mailapp, "evolution")) {

I dont think this is right, don't you want:

if (mailapp == NULL || strcmp(mailapp, "evolution") != 0) {

?  i.e. if mailapp isn't evolution?  Your test tests for mailapp is evolution.

Also you should free mailapp where you unref gconf, since the free wont getcalled if the value is set and isn't evolution.

other than that it looks ok enough to me.

On Mon, 2004-08-30 at 13:30 +0300, Niklas Nylund wrote:
> This is a patch for bug 127526, I've sent a couple of mails concerning 
> the same bug a few weeks ago. But I didn't recieve an answer to what
> I think is the final patch for this so I'm sending it again.
>
> Niklas

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer