Re: [evolution-patches] patch against bugzilla #64694 composer/e-msg-composer-attachment.c not support l10n message

["Yong.Sun" <Yong Sun Sun COM>]

I am very sorry, I just found trunk has fixed this bug.

Regards,

Not Zed 已写入:

> You actually need to do:
>
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif
>
> & include a changelog entry, thanks.
>
> On Tue, 2004-08-31 at 09:43 +0800, Yong Sun wrote:
>
> > Hi, guys,
> >
> > Please help to review this little patch.
> >
> > Description of Problem:
> > The message "Cannot attach file %s: %s" is in
> > /evolution-1.4.6/composer/e-msg-composer-attachment.c
> > ,  and the messages were not localized.
> >
> > Steps to reproduce the problem:
> > 1. Select [New] -> [Message] to compose a new message.
> > 2. Click on "Attachment" button to add an attachment.
> > 3. Enter a filename of non-existing file.
> >
> > Actual Results:
> > There appears an error message which is partially
> > not localized - see the attached screenshot from
> > De locale.
> >
> >
> > Expected Results:
> > Localized error message should be shown.
> >
> >
> > How often does this happen? 
> > Every time.
> >
> >
> > Index: e-msg-composer-attachment.c
> > ===================================================================
> > RCS file: /export/src/cvs/evolution/composer/e-msg-composer-attachment.c,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 e-msg-composer-attachment.c
> > --- e-msg-composer-attachment.c 2003/09/26 06:34:29     1.1.1.1
> > +++ e-msg-composer-attachment.c 2004/08/31 01:10:17
> > @@ -28,6 +28,8 @@
> >    attachment.  Also, this contains the code to let users edit the
> >    attachment manually. */
> >
> > +#include "config.h"
> > +
> > #include <sys/stat.h>
> > #include <string.h>
> > #include <errno.h>
> >
> >
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com <mailto:evolution-patches lists ximian com>
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
> >    
> --
> 	*Michael Zucchi* <notzed ximian com <mailto:notzed ximian com>>
> /"born to die, live to work, it's all downhill from here"/
> Novell's Evolution <http://codeblogs.ximian.com/blogs/evolution/> and 
> Free Software <http://www.gnu.org/philosophy/free-sw.html> Developer