Re: [evolution-patches] 63881 (dragging messages from vfolders)

[Not Zed <notzed ximian com>]

On Fri, 2004-08-27 at 01:18 +0100, Edward Catmur wrote:
> On Thu, 2004-08-26 at 23:41 +0100, Edward Catmur wrote:
> > If I understand correctly, the Trash and Junk vtrash folders don't need
> > the unmatched folder to exist, so it should be OK to defer creating the
> > unmatched folder till an actual vfolder is created (test !
> > CAMEL_IS_VTRASH_FOLDER(vf) in camel_vee_folder_construct). The patch to
> > do this is attached.
>
> Well, this causes a segfault when there aren't any vfolders. Fun.
> I'll look at getting the vfolder backing store when it is created.

I didn't like the patch much anyway since camel-vee-store shouldn't really know about camel-vtrash-folders itself.

I wonder if it couldn't just test if flags & CAMEL_STORE_FOLDER_PRIVATE isn't set, and then do the same thing.

I suspect the segfault could be fixed elsewhere.

The only other practical alternative i see is moving the unmatched folder onto the parent vee-store; but that would be quite a lot of work.

I'm also starting to consider using your original patch in the meantime for 2.0, since we don't have enough time to code and test anything very complex for 2.0.

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer