Re: [evolution-patches] patch for #62869 (tasks)

[Sivaiah <snallagatla novell com>]

committed,
thanks,
Siva
On Sat, 2004-08-14 at 22:45 +0200, Rodrigo Moya wrote:
> On Sat, 2004-08-14 at 16:55 +0530, Sivaiah wrote:
> > Hi,
> > In e-taks.c (default_client_cal_opened_cb) function we just unref the
> > cal object and won't make priv->default_client as NULL while handling
> > default case of status. but e_tasks_add_todo_source tries to use the
> > default client to get source and then uid from that. Uid is null since
> > default client is not a valid object and hence resulting in carsh in
> > strcmp. Attached fixes that.
> > 
> > we also remove clients from priv->clients hash table based on uri though
> > we store them based on uid. 
> > 
> > And in cal_client_opened_cb , there is no need to unref the client
> > explicitly as removing it from priv->clients will do it already.
> > 
> > The patch also corrects these.
> > 
> looks ok