Re: [evolution-patches] Patch: kerberos library location patch

[Rodney Dawes <dobey novell com>]

On Wed, 2004-08-11 at 16:43 +0200, Frederic Crozat wrote:
> As part of our AMD64 port, here is a patch I'd like to merge in HEAD
> branch (I have a similar one for 1.4 branch, but I don't think it is
> worth merging it).
> 
> It is needed when dynamic library are stored in $prefix/lib64, as they
> are on AMD64 platform.
> 
> Permission to commit ?


> +2004-03-26  Frederic Crozat  <fcrozat mandrakesoft com>

Hrmm. You should cvs up first. ;)


> +AC_ARG_WITH(krb5, [  --with-krb5=PREFIX      Location of Kerberos 5
> install dir], with_krb5="$withval", with_krb5="no")
> +AC_ARG_WITH(krb5_libs, [  --with-krb5-libs=LIBDIR Location of
> Kerberos 5 libs], with_krb5_libs="$withval",
> with_krb5_libs="$with_krb5/lib")
> +AC_ARG_WITH(krb4, [  --with-krb4=PREFIX      Location of Kerberos 4
> install dir], with_krb4="$withval", with_krb4="no")
> +AC_ARG_WITH(krb4_libs, [  --with-krb4-libs=LIBDIR Location of
> Kerberos 4 libs], with_krb4_libs="$withval",
> with_krb4_libs="$with_krb4/lib")

Should use "installation" instead of "install dir" in the summaries,
as well as "libraries" instead of "libs". We should also have similar
options for --with-FOO-includes, to be complete. Also, I believe that
the first option to AC_ARG_WITH here, for the -libs options, needs to
be FOO-libs instead of FOO_libs. Stylistically, I'd also like to see
the help summary use =DIR instead of =PREFIX or =LIBDIR.

The rest of the actual functionality looks ok though.

-- dobey