Re: [evolution-patches] eds patch for calendar auth

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2004-08-12 at 23:08 +0800, Not Zed wrote:
> On Thu, 2004-08-12 at 16:53 +0200, Rodrigo Moya wrote: 
> > On Thu, 2004-08-12 at 18:43 +0800, Not Zed wrote:
> > > 
> > > simplifies the e-cal auth stuff.  now its upto the auth callback to
> > > handle thread issues; which e-passwords does now.
> > > 
> > > this moves the thread-related issues to code that knows how to do it
> > > properly :)
> > > 
> > > i was getting consistent repeated hangs starting calendar/tasks or
> > > toggling a tasks folder on and off rapidly for a remote groupwise
> > > server.  the password code was returning a password, but the code this
> > > patch removes was getting confused and it never got the cond back to
> > > tell it to move forward.
> > > 
> > > this possibly addresses 62866 and other calendar auth-related issues.
> > >
> > does this mean the code calling e_cal_open_async needs to deal with the
> > thread-related issues? Or calling e_passwords_* from a thread will work?
> > 
> > If e_password deals with that, the patch looks great.
> 
> Sigh.  So much for describing a patch, or patch review.  The last 45K
> patch I just committed was almost entirely to do just that :)
> 
sorry, only really reviewed the calendar part :(

> I'll add the doc comments and commit. 
> 
cool thanks
-- 
Rodrigo Moya <rodrigo novell com>