Re: [evolution-patches] patch fo bug #60265 calendar

["P Chenthill" <pchenthill novell com>]

hi,

The patch has been committed. Did not remove the FIXME.

thanks, chenthill.

>>>Sivaiah N <snallagatla novell com> 08/03 1:02 pm >>>
Why are you removing FIXME there? That is still valid i guess.
Other than that looks ok to me.

Thanks,
Siva
On Mon, 2004-08-02 at 08:47 -0600, P Chenthill wrote:
>hi,
>Login into the server without checking for the cache.
> 
>thanks, chenthill.
> 
>Index: ChangeLog
>===================================================================
>RCS file: /cvs/gnome/evolution-data-server/calendar/ChangeLog,v
>retrieving revision 1.302
>diff -u -r1.302 ChangeLog
>--- ChangeLog30 Jul 2004 12:30:43 -00001.302
>+++ ChangeLog2 Aug 2004 14:30:49 -0000
>@@ -1,3 +1,10 @@
>+2004-08-02 Chenthill Palanisamy <pchenthill novell com>
>+
>+Fixes #60265
>+* backends/groupwise/e-cal-backend-groupwise.c
>+(e_cal_backend_groupwise_open): Login into the
>+server without checking for the cache.
>+
>2004-07-30 Harish Krishnaswamy <kharish novell com>
> 
>Fixes #59335
>Index: backends/groupwise/e-cal-backend-groupwise.c
>===================================================================
>RCS file: /cvs/gnome/evolution-data-
>server/calendar/backends/groupwise/e-cal-backend-groupwise.c,v
>retrieving revision 1.79
>diff -u -r1.79 e-cal-backend-groupwise.c
>--- backends/groupwise/e-cal-backend-groupwise.c28 Jul 2004 12:00:42 -
>00001.79
>+++ backends/groupwise/e-cal-backend-groupwise.c2 Aug 2004 14:30:50 -
>0000
>@@ -438,24 +438,11 @@
> 
>g_mutex_lock (priv->mutex);
> 
>-/* create the local cache */
>- /* FIXME: if the cache already exists - read it and get deltas. */
>-if (priv->cache) {
>-g_mutex_unlock (priv->mutex);
>-g_object_ref (priv->cnc);
>-g_object_ref (priv->cache);
>-g_timeout_add (CACHE_REFRESH_INTERVAL, (GSourceFunc) get_deltas,
>(gpointer) cbgw);
>-priv->mode = CAL_MODE_REMOTE;
>-
>- return GNOME_Evolution_Calendar_Success;
>-}
>-
>cbgw->priv->read_only = FALSE;
>priv->mode = CAL_MODE_LOCAL;
>priv->username = g_strdup (username);
>priv->password = g_strdup (password);
> 
>- /* FIXME: no need to set it online here when we implement the
>online/offline stuff correctly */
>status = connect_to_server (cbgw);
> 
>g_mutex_unlock (priv->mutex);