Re: [evolution-patches] patch fo bug #60265 calendar



The timeout handler is already present in connect_to_server for refreshing the cache, perhaps two getDelta request were being sent every time. So removed the one present in _open method.
thanks, chenthill.

>>>Rodrigo Moya <rodrigo novell com> 08/03 6:26 pm >>>
On Mon, 2004-08-02 at 08:47 -0600, P Chenthill wrote:
>hi,
>Login into the server without checking for the cache.

looks ok, except one thing:

>Index: backends/groupwise/e-cal-backend-groupwise.c
>===================================================================
>RCS file: /cvs/gnome/evolution-data-
>server/calendar/backends/groupwise/e-cal-backend-groupwise.c,v
>retrieving revision 1.79
>diff -u -r1.79 e-cal-backend-groupwise.c
>--- backends/groupwise/e-cal-backend-groupwise.c28 Jul 2004 12:00:42 -
>00001.79
>+++ backends/groupwise/e-cal-backend-groupwise.c2 Aug 2004 14:30:50 -
>0000
>@@ -438,24 +438,11 @@

>g_mutex_lock (priv->mutex);

>-/* create the local cache */
>- /* FIXME: if the cache already exists - read it and get deltas. */
>-if (priv->cache) {
>-g_mutex_unlock (priv->mutex);
>-g_object_ref (priv->cnc);
>-g_object_ref (priv->cache);
>-g_timeout_add (CACHE_REFRESH_INTERVAL, (GSourceFunc) get_deltas,
>(gpointer) cbgw);
>-priv->mode = CAL_MODE_REMOTE;
>-
we should still install the timeout handler for refreshing the cache, so
you should not remove that call, but, maybe, move it to another place,
like connect_to_server.


>- return GNOME_Evolution_Calendar_Success;
>-}
>-
>cbgw->priv->read_only = FALSE;
>priv->mode = CAL_MODE_LOCAL;
>priv->username = g_strdup (username);
>priv->password = g_strdup (password);

>- /* FIXME: no need to set it online here when we implement the
>online/offline stuff correctly */
>status = connect_to_server (cbgw);

that FIXME still applies, so don't remove it
--
Rodrigo Moya <rodrigo novell com>

_______________________________________________
evolution-patches mailing list
evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]