Re: [evolution-patches] camel provider changes for connector

[Sarfraaz Ahmed <asarfraaz novell com>]

Hi,
>     This should be a string list type, not a string type.
>     
>     e.g.:
>     list = gconf_client_get_list (config->gconf, "/apps/evolution/mail/labels", GCONF_VALUE_STRING, NULL);
>     you get a GSList of char * you need to free yourself, etc.  Then you don't need to split/join the values, you can just use the list directly.
>     
>     But I think you should do this, even though it might do funny things for people who have run the current version (i dont know what gconf will do if you change the type of the value).
>     
You mean current version of gconf ?? Anyway, I shall do this change and send the updated patch ...

>     And for future refreence, when you want to do things like concatenate a number of strings, or form a string from a list its more efficient/readable/simpler to use a GString.
Sure, thanks

>     I dont think it should be a stock button, although in code you can make it a stock-looking button with an "Accept License" label.  I do not know the answer to this, but I do know from the HIG error message work I did that directional labels are preferred.  I don't know what they say about icons.
>     
Well, i am not much aware of these guidelines yet. Planning to go through them sometime. For the time being, i just created an icon for the "Accept License" button. This now kinda looks good to me. I have attached that snapshot below. I guess, i should go with that for now, till we get the feedback on that HIG bug i filed.

Michael

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.

        Thanks
                        --     Sarfraaz Ahmed <asarfraaz novell com>

Attachment: evo-license-stock-2.jpg
Description: JPEG image