Re: [evolution-patches] camel provider changes for connector

[Not Zed <notzed ximian com>]

On Fri, 2004-04-23 at 19:53 +0530, Sarfraaz Ahmed wrote:

Hi,

Thanks a lot for the review comments. Its a pleasure to see my patch getting beautified

As we talked on irc, i have made the changes you mentioned. Attached is the new patch file.

Changes done are as follows :

* Added the response values, and removed the signal calbacks for the dialog buttons
* Made the dialog title and the dialog label on top generic. The providers now need to send the license_name they desire to be displayed on the dialog.

Sweet.
>     * Modified the gconf entry to be a string type, where each provider's protocol name is added to the list [ once the licesnse agreement is accepted ].

This should be a string list type, not a string type.

e.g.:
	list = gconf_client_get_list (config->gconf, "/apps/evolution/mail/labels", GCONF_VALUE_STRING, NULL);
you get a GSList of char * you need to free yourself, etc.  Then you don't need to split/join the values, you can just use the list directly.

But I think you should do this, even though it might do funny things for people who have run the current version (i dont know what gconf will do if you change the type of the value).

And for future refreence, when you want to do things like concatenate a number of strings, or form a string from a list its more efficient/readable/simpler to use a GString.

Also created the bug for the HIG modifications. The bug# is 57513.

I am attaching a snapshot of the dialog buttons which now use the stock button for "no" and just a "accpet license" button. I somehow feel that these both do not look good together .. It would be better if we could also have a stock button for accept license. What are your thoughts on this ?? [ May be i should file a bug for this in glade ?? ]

I dont think it should be a stock button, although in code you can make it a stock-looking button with an "Accept License" label.  I do not know the answer to this, but I do know from the HIG error message work I did that directional labels are preferred.  I don't know what they say about icons.

 Michael

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.