[evolution-patches] Bug in Netscape mail importer

[David Malcolm <dmalcolm redhat com>]

I tried building with -Werror and this showed up - looks like
Evolution's Netscape mail importer could occasionally try to g_free
whatever value the unused local variable "url" was uninitialized with.

I believe this would occasionally cause random crashes when importing
Netscape IMAP accounts.

Caveat:  compiles, though I haven't test-run the new code yet.

Dave Malcolm

? mail/e-searching-tokenizer.loT
? mail/em-folder-tree.loT
? mail/em-format-html-quote.loT
? mail/em-format.loT
? mail/em-subscribe-editor.loT
? mail/mail-send-recv.loT
? mail/mail-vfolder.loT
? mail/importers/evolution-outlook-importer.loT
? mail/importers/mail-importer.loT
Index: mail/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3244
diff -u -p -r1.3244 ChangeLog
--- mail/ChangeLog	15 Apr 2004 20:50:04 -0000	1.3244
+++ mail/ChangeLog	16 Apr 2004 21:42:50 -0000
@@ -1,3 +1,8 @@
+2004-04-16  David Malcolm  <dmalcolm redhat com>
+
+	* importers/netscape-importer.c (netscape_import_accounts):
+	Removed unused and uninitialised "url" local that gets g_free-ed
+
 2004-04-15  Jeffrey Stedfast  <fejj ximian com>
 
 	* mail-config.c (config_write_style): Change the message display
Index: mail/importers/netscape-importer.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/importers/netscape-importer.c,v
retrieving revision 1.16
diff -u -p -r1.16 netscape-importer.c
--- mail/importers/netscape-importer.c	1 Apr 2004 19:47:06 -0000	1.16
+++ mail/importers/netscape-importer.c	16 Apr 2004 21:42:50 -0000
@@ -1545,7 +1545,7 @@ netscape_import_accounts (NsImporter *im
 
 			servers = g_strsplit (imap, ",", 0);
 			for (i = 0; servers[i] != NULL; i++) {
-				char *serverstr, *name, *url;
+				char *serverstr, *name;
 				const char *username;
 				EAccount *imap;
 
@@ -1580,7 +1580,6 @@ netscape_import_accounts (NsImporter *im
 				imap->enabled = TRUE;
 
 				mail_config_add_account(imap);
-				g_free (url);
 				g_free (serverstr);
 			}