Re: [evolution-patches] Pl. discard the earlier patch:

[Suresh Chandrasekharan <Suresh Chandrasekharan Eng Sun COM>]

What's in the patch is weird ?

This is as per Jeff feedback that we need to unselect the selected text, 

> the patch is wrong. focusing the entry widget that we need the user to
> fill out is proper behaviour.
> 
> the problem is that by default, when an entry widget is focused in gtk2,
> gtk2 decides to do something entirely stupid: select all the text
> 
> what you need to do is unselect the text

So all the grab_focus callback signals which is hooked on by a 
gtk_signal_connect_after. This particular handler will be called after other 
handlers, here gtk_entry_grab_focus. It's just patching up the undesired effect 
of the gtk_entry_grab_focus. 

I can remove the grab_focus callbacks, but when tabbing between text widgets 
highlights do happen.

Lemme know whether that's OK.

Thanks,
Suresh
>Date: Mon, 29 Sep 2003 08:58:00 -0400
>From: Dan Winship <danw ximian com>
>Subject: Re: [evolution-patches] Pl. discard the earlier patch:	
evolution/mail patch for 40917
>To: Not Zed <notzed ximian com>
>Cc: Suresh Chandrasekharan <suresh chandrasekharan sun com>, 
evolution-patches ximian com, sceri-evolution ximian com, anna ximian com
>MIME-version: 1.0
>Content-transfer-encoding: 7bit
>X-BeenThere: evolution-patches lists ximian com
>Delivered-to: evolution-patches ximian com
>X-Spam-Status: No, hits=-31.8 required=5.0	
tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, 
RCVD_IN_OSIRUSOFT_COM,REFERENCES,REPLY_WITH_QUOTES, USER_AGENT_XIMIAN	
version=2.53
>X-Spam-Level: 
>X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp)
>X-Mailman-Version: 2.0.13
>List-Post: <mailto:evolution-patches lists ximian com>
>List-Subscribe: <http://lists.ximian.com/mailman/listinfo/evolution-patches>, 
<mailto:evolution-patches-request lists ximian com?subject=subscribe>
>List-Unsubscribe: <http://lists.ximian.com/mailman/listinfo/evolution-patches>, 
<mailto:evolution-patches-request lists ximian com?subject=unsubscribe>
>List-Archive: <http://lists.ximian.com/archives/public/evolution-patches/>
>List-Help: <mailto:evolution-patches-request lists ximian com?subject=help>
>List-Id: patches against evolution go here <evolution-patches.lists.ximian.com>
>
>On Sun, 2003-09-28 at 20:37, Not Zed wrote:
>> Hmm, i'm not sure about this fix.
>> 
>> - it removes functionality, that of highlighting an incomplete field
>
>That's what I thought at first, but it doesn't actually. The
>highlighting-incomplete-field is only in the account editor. Suresh's
>patch is to the druid, which never does that because you can't even
>click "Next" until all the fields are filled in.
>
>I agree that the rest of the patch is weird. (I think that was based on
>Jeff's comments though.)
>
>-- Dan
>_______________________________________________
>Evolution-patches mailing list
>Evolution-patches lists ximian com
>http://lists.ximian.com/mailman/listinfo/evolution-patches

Thanks & Regards,
Suresh