Re: [evolution-patches] patch for review(45775 calendar keyboard navigation)

[Anna Marie Dirks <anna ximian com>]

Hello everybody.

Thank you for this patch! It is exciting to see the Calendar getting so
much attention. Still, I believe that we need to work on this patch just
a little more.

You see, I think that there is a hidden bug here, which is making it
difficult to understand how to address this bug. The hidden bug is: 
There is no "Open" item in the "File" menu of the Calendar. There should
be one. It should operate like the "Open Message" item in the Mail
component.

The shortcut for that item should be Ctl+O. 

I think that the reason Wu used the alt modifier in this patch is that
the only menu which currently exists for opening calendar items is the
"Open" item in the context menu. The accelerator for the item, in
English, is Alt+O. Still, for the reasons that Ettore cited in his mail,
this is not an optimal solution.

What I really think that we need is for *Ctl+O* to work in the calendar
for opening items, and the Open item to be added to the File menu. 

What do you guys think?

Thanks again. 
best wishes,
Anna

On Mon, 2003-09-29 at 12:38, Ettore Perazzoli wrote:
> 
> Alt-letter is for widget accelerators, like menus and buttons. 
> 
> But in this case, it's a shortcut for a menu item, so it should use
> Ctrl-something instead (and probably just be bound through the Bonobo
> menu shortcut stuff, and not manually through the widget).
> 
> If you hardcode it to Alt-O there is also a chance that some translation
> of Evolution will have a menu starting with "_O" and that will cause the
> widget shortcut not to work.
> 
> Or am I missing something?
> 
> -- Ettore

-- 
Anna Marie Dirks <anna ximian com>