[evolution-patches] RESEND: evolution-1-4-branch patch for 40917

[Suresh Chandrasekharan <suresh chandrasekharan sun com>]

Hi All,
	Pl. see te attached modified patch for "40917 Backspace shouldn't
highlight the whole remaining string in Setup Assistant". Modfied as per
Dan/Jeff feedback of the earlier one. This one also removed the initial
highlighting of the text in the Setup Assistant fileds.

Pl. check whether this is fine.

Regards,
Suresh

On Fri, 2003-09-26 at 12:16, Dan Winship wrote:
> On Fri, 2003-09-26 at 14:56, Suresh Chandrasekharan wrote:
> > does it imply patch is right ?
> 
> Well, commenting code out isn't right. If the code is doing the right
> thing, it should stay there, and if it's not, it should be removed, not
> just commented out.
> 
> And looking at it some more, I have to agree that the grab_focus call is
> just wrong. There's never any case where it would actually do anything
> useful. So the grab_focus calls in each of the *_changed functions in
> mail-config-druid.c should all be removed.
> 
> -- Dan
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

? .mail-config-druid.c.swp
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.2761.2.26
diff -u -r1.2761.2.26 ChangeLog
--- ChangeLog	25 Sep 2003 16:09:12 -0000	1.2761.2.26
+++ ChangeLog	26 Sep 2003 17:06:49 -0000
@@ -1,3 +1,8 @@
+2003-09-26  Suresh Chandrasekharan <suresh chandrasekharan sun com>
+
+	* mail-config-druid.c: (identity_changed) Fix for 40917 "Backspace 
+	shouldn't highlight the whole remaining string in Setup Assistant. 
+
 2003-09-25  Rodney Dawes  <dobey ximian com>
 
 	* mail-send-recv.c: Make the dialog more HIG-compliant by fixing
Index: mail-config-druid.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-config-druid.c,v
retrieving revision 1.100
diff -u -r1.100 mail-config-druid.c
--- mail-config-druid.c	16 Apr 2003 17:03:11 -0000	1.100
+++ mail-config-druid.c	26 Sep 2003 17:06:49 -0000
@@ -126,8 +126,10 @@
 	
 	config_wizard_set_buttons_sensitive (mcw, TRUE, next_sensitive);
 	
+/*
 	if (!next_sensitive)
 		gtk_widget_grab_focus (incomplete);
+*/
 }
 
 static void