Re: [evolution-patches] evolution-1-4-branch patch for 40917
- From: Dan Winship <danw ximian com>
- To: Suresh Chandrasekharan <Suresh Chandrasekharan Eng Sun COM>
- Cc: evolution-patches ximian com, sceri-evolution sun com
- Subject: Re: [evolution-patches] evolution-1-4-branch patch for 40917
- Date: Fri, 26 Sep 2003 15:16:38 -0400
On Fri, 2003-09-26 at 14:56, Suresh Chandrasekharan wrote:
> does it imply patch is right ?
Well, commenting code out isn't right. If the code is doing the right
thing, it should stay there, and if it's not, it should be removed, not
just commented out.
And looking at it some more, I have to agree that the grab_focus call is
just wrong. There's never any case where it would actually do anything
useful. So the grab_focus calls in each of the *_changed functions in
mail-config-druid.c should all be removed.
-- Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]