Re: [evolution-patches] Please review my patch for bug #48145

[Ettore Perazzoli <ettore ximian com>]

On Wed, 2003-09-10 at 09:02, Charles Zhang wrote:
> Thank you, Ettore.
> I have thought that the function name should more or less stand for
> its real action, but maybe a regular name is the best choice, I have
> fix it as you advised.

In my code I like to use the same name as the signal, so I know when the
function is invoked just by looking at it (and if there are multiple
callbacks for signals with the same name I prepend with the name of the
widget, e.g. "ok_clicked_callback", "cancel_clicked_callback" or
something).

However it's not a big deal, especially given that that specific file
doesn't really follow the same coding convention I normally use...  ;-)

> Then what about these words, "Do you really want to exit Evolution
> Setup Assistant Program?"

I don't think it's called "Evolution Setup Assistant Program" anywhere? 
I think Anna should just come up with the wording. :)

> Another problem I found is about the buttons on the confirmation
> dialog.
> Anyway, it is a warning or caution dialog, not for select.
> So I should use GTK_BUTTONS_OK_CANCEL but not GTK_BUTTONS_YES_NO here,
> do you think so?

Actually, it should maybe be "Quit" / "Don't Quit" as per the HIG?

-- Ettore