Re: [evolution-patches] Please review my patch for bug #48145



> +static gboolean
> +startup_wizard_escape( GtkWidget   *widget,
> +		       GdkEventKey *keyev,
> +		       SWData 	   *data )

This should probably be called key_press_event_callback() or something.

> +		confirm_dialog = gtk_message_dialog_new (widget, GTK_DIALOG_MODAL,
> +							 GTK_MESSAGE_QUESTION, GTK_BUTTONS_YES_NO,
> +							 "Are you sure to quit?");

I don't think this is proper English, and probably it should have some
more information...  Anna, can you come up with some text for this? 

It should also be marked for translation.  (And since this is new text,
the patch should only be applied to HEAD.)

The rest looks good.

-- Ettore



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]