Re: [evolution-patches] fix for bug #45412 (drafts & sent not settable)

[Jeffrey Stedfast <fejj ximian com>]

new updated patch

On Wed, 2003-09-10 at 10:59 -0500, Not Zed wrote:
> Do we now cater to the original problem it was trying to fix?
> 
> i.e. if the destination store changes, is it propagated to anything
> that used to reference it?
> 
> Probably not ... although we should.
> 
> Perhaps we need some indirection here in the url's, somehow.
> 
> Should we just pop up a box saying ' you can't do that', although why
> you can't isn't obvious ...
> 
> I think, just don't do the compare, and eventually have it do
> something to resolve changes automatically.
> 
> On Wed, 2003-09-10 at 10:54 -0400, Jeffrey Stedfast wrote: 
> > yea, it probably shouldn't do the uri compare at all. Shoudl I redo
> > the patch to allow the user to set any folder in any of his/her
> > accounts as a drafts/sent folder?
> > 
> > Jeff
> > 
> > On Tue, 2003-09-09 at 16:59, Not Zed wrote:
> >                            From: 
> > Not Zed <notzed ximian com>
> >                              To: 
> > Jeffrey Stedfast <fejj ximian com>
> >                              Cc: 
> > evolution-patches ximian com
> >                         Subject: 
> > Re: [evolution-patches] fix for
> > bug #45412 (drafts & sent not
> > settable)
> >                            Date: 
> >  Tue, 09 Sep 2003 15:59:01 -0500 
> > (16:59 EDT)
> >                          Mailer: 
> > Ximian Evolution 1.5 
> >         The only problem i have here is that the code was
> >         speficially added at
> >         one point in the past:
> >         
> >         2001-09-28 Jeffrey Stedfast <fejj ximian com>
> >         
> >         * mail-local.c (mail_local_provider_init): Setup the
> >         url_hash and
> >         url_equal functions for the local provider.
> >         
> >         * mail-account-gui.c (mail_account_gui_save): Add code here
> >         to
> >         check to make sure that the Drafts and Sent folders are
> >         pointing
> >         to valid urls. This is kinda nasty and only really solves
> >         the case
> >         where the user changes, say, his imap server or
> >         something. Unfortunately we still have the problem where if
> >         account A's sent/drafts folders point to account B's store
> >         and the
> >         user changes the url for account B
> >         
> >         
> >         Why force it to local/the same server, it may as well not
> >         have the check
> >         at all?
> >         
> >         
> >         On Tue, 2003-09-09 at 16:34 -0400, Jeffrey Stedfast wrote:
> >         > as long as the user wanted to use the local Sent or Drafts
> >         folder *or*
> >         > if he only cared to use a folder on his/her imap server -
> >         it worked.
> >         > otherwise it doesn't. This patch allows the user to set
> >         *any* local
> >         > folder as his sent/drafts folder as well as any folder on
> >         the imap
> >         > server.
> >         
> >         > should be applied to both branches
> >         > 
> >         > Jeff
> >         > 
> >         > -- 
> >         > Jeffrey Stedfast
> >         > Evolution Hacker - Ximian, Inc.
> >         > fejj ximian com  - www.ximian.com
> >         
> >         _______________________________________________
> >         Evolution-patches mailing list
> >         Evolution-patches lists ximian com
> >         http://lists.ximian.com/mailman/listinfo/evolution-patches
> >         
> > -- 
> > Jeffrey Stedfast
> > Evolution Hacker - Ximian, Inc.
> > fejj ximian com  - www.ximian.com
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.2761.2.20
diff -u -r1.2761.2.20 ChangeLog
--- ChangeLog	10 Sep 2003 01:25:17 -0000	1.2761.2.20
+++ ChangeLog	10 Sep 2003 20:04:16 -0000
@@ -1,3 +1,14 @@
+2003-09-10  Jeffrey Stedfast  <fejj ximian com>
+
+	* mail-account-gui.c (mail_account_gui_save): Allow the user to
+	select any fodler for his/her Drafts and Sent folders. Fixes bug
+	#45412.
+
+2003-09-08  Jeffrey Stedfast  <fejj ximian com>
+
+	* mail-display.c (invisible_selection_clear_event_callback): Don't
+	clear the clipboard. Fixes bug #48203.
+
 2003-09-09  Not Zed  <NotZed Ximian com>
 
 	* mail-send-recv.c (build_dialogue): use an eclippedlabel for
Index: mail-account-gui.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-account-gui.c,v
retrieving revision 1.133.4.1
diff -u -r1.133.4.1 mail-account-gui.c
--- mail-account-gui.c	1 Aug 2003 18:39:01 -0000	1.133.4.1
+++ mail-account-gui.c	10 Sep 2003 20:04:20 -0000
@@ -1862,7 +1862,6 @@
 {
 	EAccount *account, *new;
 	CamelProvider *provider = NULL;
-	CamelURL *source_url = NULL, *url;
 	gboolean is_new = FALSE;
 	const char *new_name;
 	gboolean is_storage;
@@ -1907,10 +1906,8 @@
 	
 	/* source */
 	save_service (&gui->source, gui->extra_config, new->source);
-	if (new->source->url) {
+	if (new->source->url)
 		provider = camel_session_get_provider (session, new->source->url, NULL);
-		source_url = provider ? camel_url_new (new->source->url, NULL) : NULL;
-	}
 	
 	new->source->auto_check = gtk_toggle_button_get_active (gui->source_auto_check);
 	if (new->source->auto_check)
@@ -1924,33 +1921,20 @@
 		save_service (&gui->transport, NULL, new->transport);
 	
 	/* Check to make sure that the Drafts folder uri is "valid" before assigning it */
-	url = source_url && gui->drafts_folder_uri ? camel_url_new (gui->drafts_folder_uri, NULL) : NULL;
-	if (mail_config_get_account_by_source_url (gui->drafts_folder_uri) ||
-	    (url && provider->url_equal (source_url, url))) {
+	if (mail_config_get_account_by_source_url (gui->drafts_folder_uri)) {
 		new->drafts_folder_uri = g_strdup (gui->drafts_folder_uri);
 	} else {
 		/* assign defaults - the uri is unknown to us (probably pointed to an old source url) */
 		new->drafts_folder_uri = g_strdup (default_drafts_folder_uri);
 	}
 	
-	if (url)
-		camel_url_free (url);
-	
 	/* Check to make sure that the Sent folder uri is "valid" before assigning it */
-	url = source_url && gui->sent_folder_uri ? camel_url_new (gui->sent_folder_uri, NULL) : NULL;
-	if (mail_config_get_account_by_source_url (gui->sent_folder_uri) ||
-	    (url && provider->url_equal (source_url, url))) {
+	if (mail_config_get_account_by_source_url (gui->sent_folder_uri)) {
 		new->sent_folder_uri = g_strdup (gui->sent_folder_uri);
 	} else {
 		/* assign defaults - the uri is unknown to us (probably pointed to an old source url) */
 		new->sent_folder_uri = g_strdup (default_sent_folder_uri);
 	}
-	
-	if (url)
-		camel_url_free (url);
-	
-	if (source_url)
-		camel_url_free (source_url);
 	
 	new->always_cc = gtk_toggle_button_get_active (gui->always_cc);
 	new->cc_addrs = g_strdup (gtk_entry_get_text (gui->cc_addrs));