Re: [evolution-patches] fix for bug #45412 (drafts & sent not settable)



Do we now cater to the original problem it was trying to fix?

i.e. if the destination store changes, is it propagated to anything that used to reference it?

Probably not ... although we should.

Perhaps we need some indirection here in the url's, somehow.

Should we just pop up a box saying ' you can't do that', although why you can't isn't obvious ...

I think, just don't do the compare, and eventually have it do something to resolve changes automatically.

On Wed, 2003-09-10 at 10:54 -0400, Jeffrey Stedfast wrote:
yea, it probably shouldn't do the uri compare at all. Shoudl I redo the patch to allow the user to set any folder in any of his/her accounts as a drafts/sent folder?

Jeff

On Tue, 2003-09-09 at 16:59, Not Zed wrote:
From: 
Not Zed <notzed ximian com>
To: 
Jeffrey Stedfast <fejj ximian com>
Cc: 
evolution-patches ximian com
Subject: 
Re: [evolution-patches] fix for bug #45412 (drafts & sent not settable)
Date: 
 Tue, 09 Sep 2003 15:59:01 -0500 (16:59 EDT)
Mailer: 
Ximian Evolution 1.5
The only problem i have here is that the code was speficially added at
one point in the past:

2001-09-28 Jeffrey Stedfast <
fejj ximian com>

* mail-local.c (mail_local_provider_init): Setup the url_hash and
url_equal functions for the local provider.

* mail-account-gui.c (mail_account_gui_save): Add code here to
check to make sure that the Drafts and Sent folders are pointing
to valid urls. This is kinda nasty and only really solves the case
where the user changes, say, his imap server or
something. Unfortunately we still have the problem where if
account A's sent/drafts folders point to account B's store and the
user changes the url for account B


Why force it to local/the same server, it may as well not have the check
at all?


On Tue, 2003-09-09 at 16:34 -0400, Jeffrey Stedfast wrote:

> as long as the user wanted to use the local Sent or Drafts folder *or*
> if he only cared to use a folder on his/her imap server - it worked.
> otherwise it doesn't. This patch allows the user to set *any* local
> folder as his sent/drafts folder as well as any folder on the imap
> server.


> should be applied to both branches
>
> Jeff
>
> --
> Jeffrey Stedfast
> Evolution Hacker - Ximian, Inc.
>
fejj ximian com  - www.ximian.com

_______________________________________________
Evolution-patches mailing list

Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches


-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]