These all look good to me. -- dobey On Wed, 2003-09-03 at 12:39, Dan Winship wrote: > A while back, someone added -no-undefined to a bunch of LDFLAGS "which > is necessary for building shared library on some platforms (e.g. Win32, > BeOS).". But the libtool docs say: > > `-no-undefined' > Declare that OUTPUT-FILE does not depend on any other libraries. > Some platforms cannot create shared libraries that depend on other > libraries (*note Inter-library dependencies::). > > and that is not true of any of our libraries. Adding -no-undefined makes > them not build on Darwin/OS X, since it actually checks that there are > no undefined symbols. > > The Sun people already removed some of the -no-undefineds because they > were breaking Solaris. These patches remove the rest. > > It also does two other things in gtkhtml: removes the "-static" from > testgtkhtml's compile flags (which was removed once before but then got > accidentally readded as part of an unrelated commit) and adds "-module" > to libgnome-gtkhtml-editor's LDFLAGS, which is a no-op on Linux, but > required on Darwin. > > Patches for both stable and head attached. > > -- Dan
Attachment:
signature.asc
Description: This is a digitally signed message part