Re: [evolution-patches] gal and gtkhtml Makefile patches for Darwin

[Larry Ewing <lewing ximian com>]

The gtkhtml patches look fine to me.

--Larry

On Wed, 2003-09-03 at 12:39 -0400, Dan Winship wrote:
> A while back, someone added -no-undefined to a bunch of LDFLAGS "which
> is necessary for building shared library on some platforms (e.g. Win32,
> BeOS).". But the libtool docs say:
> 
>         `-no-undefined'
>              Declare that OUTPUT-FILE does not depend on any other libraries.
>              Some platforms cannot create shared libraries that depend on other
>              libraries (*note Inter-library dependencies::).
> 
> and that is not true of any of our libraries. Adding -no-undefined makes
> them not build on Darwin/OS X, since it actually checks that there are
> no undefined symbols.
> 
> The Sun people already removed some of the -no-undefineds because they
> were breaking Solaris. These patches remove the rest.
> 
> It also does two other things in gtkhtml: removes the "-static" from
> testgtkhtml's compile flags (which was removed once before but then got
> accidentally readded as part of an unrelated commit) and adds "-module"
> to libgnome-gtkhtml-editor's LDFLAGS, which is a no-op on Linux, but
> required on Darwin.
> 
> Patches for both stable and head attached.
> 
> -- Dan
> 
> ______________________________________________________________________
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/gal/ChangeLog,v
> retrieving revision 1.800.2.3
> diff -u -r1.800.2.3 ChangeLog
> --- ChangeLog	20 Aug 2003 17:58:08 -0000	1.800.2.3
> +++ ChangeLog	3 Sep 2003 16:18:57 -0000
> @@ -1,3 +1,8 @@
> +2003-09-03  Dan Winship  <danw ximian com>
> +
> +	* gal/Makefile.am (libgal_2_0_la_LDFLAGS): Remove -no-undefined
> +	here too.
> +
>  2003-08-20  Suresh Chandrasekharan  <suresh chandrasekharan sun com>
>  
>  	* gal/util/e-util.c (e_filename_make_safe): Fix for 47474
> Index: gal/Makefile.am
> ===================================================================
> RCS file: /cvs/gnome/gal/gal/Makefile.am,v
> retrieving revision 1.68
> diff -u -r1.68 Makefile.am
> --- gal/Makefile.am	31 Jul 2003 04:04:04 -0000	1.68
> +++ gal/Makefile.am	3 Sep 2003 16:18:57 -0000
> @@ -6,7 +6,6 @@
>  lib_LTLIBRARIES = libgal-2.0.la
>  
>  libgal_2_0_la_LDFLAGS = -version-info $(GAL_CURRENT):$(GAL_REVISION):$(GAL_AGE) \
> -		    -no-undefined \
>  		    $(ICONV_LIBS)
>  libgal_2_0_la_SOURCES = bogus_automake_hack.c
>