Re: [evolution-patches] Patch for mail-config glade higification

[Anna Marie Dirks <anna ximian com>]

Hi Martyn,

Thanks for your prompt reply.

> > 1. The "Server Type" labels on the Receiving Mail and Sending Mail pages
> > are not correctly capitalized.
> 
> Done, however, I only see this on the "Receiving Mail" page.

Funny, it is definitely wrong on both pages here. At any rate, as long
as it gets fixed, I'm happy.

> > 2. The "Restore Defaults" button should have an icon, and an alignment
> > around it so as to restrict its size. This button should also have an
> > access key.
> 
> Which icon? Previously it had no icon that I recall.  Should it be the
> "Revert" stock icon?  About the alignment of the button see [1].

Yes, stock "revert" is about the best we can do right now. 

> 
> > 4. There is an inordinate amount of vertical space around the hrule on
> > the Sending Mail tab. (The amount of space there is inconsistent with
> > other tabs.) Let me know if you need a screenshot to see this.
> 
> Yes, I had noticed this.  The label has no CR in the glade file.  I can
> only presume it has been set with a CR at run time?  This was one of the
> code changes I was going to look into.

Yeah -- I believe that you need to look in the subdirectories within the
evolution/camel/providers directory at the various *-provider.c files,
and update those messages to remove any wanton newlines.


> > 5. The "Add new signature.." button is incorrectly capitalized, and
> > lacks an icon.
> 
> Done.  Note, I have also taken the liberty of capitalising "Check for
> Supported Types" too.

Thanks. :)

> > 
> > 6. When you get around to fixing the "Receiving Options" stuff, please
> > note that most of the items enclosed in frames on that page lack
> > appropriate accelerators. 
> 
> This page needs further work.  As I mentioned in my original mail, there
> are some options which are added in run time based on the mail settings
> the user configures.  It would be much better if those settings existed
> in the glade file and were hidden or shown accordingly, comments?

Well, from a usability-perspective (the only one that I'm paid to care
about :), I don't think it makes a ton of difference exactly *how* the
settings come to appear in the dialog, as long as they do. But I agree
with you that putting those settings into the glade file would make
updating their interfaces much easier, and is probably a worthwhile
move.


>  
> If you want me
> to make it look as I think it should to improve usability, I shall do
> that in my next patch.

Well, I can't promise that we have entrely overlapping ideas of what
would improve its usability. However, I am more than happy to see your
ideas (if you have time to implement them), and to consider them
seriously. Thank you in advance for your willingness to do this work!


> [2] As far as removing some of the messages (e.g. "note: ....") is
> concerned, I tend to agree with you.  It clutters the dialog and gives
> the user more things to focus on which I feel is unnecessary when the
> dialog is as detailed as currently is.  We can use tool tips for this,
> after all, that is what they're there for.  :)

Indeed. 

> 
> Also, you mentioned nothing of the "mail preferences" and "composer
> preferences" which I also updated, did you miss them? 

Eek! I guess that since your original mail only referenced the account
editor explicitly, I assumed that all of your changes had been added to
it. :) I have now checked over this work as well, and have only minor
comments: 

1. The HIG has decreed that notebook tabs ought not to have their own
accelerators, so those can/should be removed in the interest of
improving the accelerators within the various notebook pages. 

2. The "Restore Defaults" button on the colors tab of the mail
preferences page should be capitalized properly, and should ideally have
an icon as we talked about above.

cheers,
Anna
-- 
Anna Marie Dirks <anna ximian com>