Re: [evolution-patches] Patch for mail-config glade higification

[Martyn Russell <ginxd btopenworld com>]

On Wed, 2003-10-22 at 17:12, Anna Marie Dirks wrote:
> Martyn,
> 
> For the most part, this patch looks good. Thank you for spending time on
> this. I have a few concerns about it: 

No problem :)

> 
> 1. The "Server Type" labels on the Receiving Mail and Sending Mail pages
> are not correctly capitalized.

Done, however, I only see this on the "Receiving Mail" page.

> 
> 2. The "Restore Defaults" button should have an icon, and an alignment
> around it so as to restrict its size. This button should also have an
> access key.

Which icon? Previously it had no icon that I recall.  Should it be the
"Revert" stock icon?  About the alignment of the button see [1].

> 
> 3. "Authentication Type" is incorrectly capitalized on the Sending Mail
> page. Ideally, we'd change the "Authentication type" label to just
> "Type", and would pack the authentication widgets into a table so as to
> give that portion of the dialog some more symmetry. 

Ok, see [1].

> 
> 4. There is an inordinate amount of vertical space around the hrule on
> the Sending Mail tab. (The amount of space there is inconsistent with
> other tabs.) Let me know if you need a screenshot to see this.

Yes, I had noticed this.  The label has no CR in the glade file.  I can
only presume it has been set with a CR at run time?  This was one of the
code changes I was going to look into.

> 
> 4. I'd really like us to get rid of the various help messages in this
> dialog. Specifically, the notes about password prompting, the
> descriptions of server types, and the explanation of the use of the
> account name can all be removed as far as I am concerned. Ettore, other
> hackers wish to differ? 

Ok, I to some extent agree, see [2].

> 
> 5. The "Add new signature.." button is incorrectly capitalized, and
> lacks an icon.

Done.  Note, I have also taken the liberty of capitalising "Check for
Supported Types" too.
 
> 
> 6. When you get around to fixing the "Receiving Options" stuff, please
> note that most of the items enclosed in frames on that page lack
> appropriate accelerators. 

This page needs further work.  As I mentioned in my original mail, there
are some options which are added in run time based on the mail settings
the user configures.  It would be much better if those settings existed
in the glade file and were hidden or shown accordingly, comments?

> 

[1] I did the modifications without changing the interface and basic
design too much, some people dislike that.  As a result, I have held
back on some things which I feel could be a lot better.  If you want me
to make it look as I think it should to improve usability, I shall do
that in my next patch.

[2] As far as removing some of the messages (e.g. "note: ....") is
concerned, I tend to agree with you.  It clutters the dialog and gives
the user more things to focus on which I feel is unnecessary when the
dialog is as detailed as currently is.  We can use tool tips for this,
after all, that is what they're there for.  :)


I will fix those things which you have spotted and make some alterations
which I feel make the dialog easier to use, plus add to the mnemonics of
some of the widgets.

Also, you mentioned nothing of the "mail preferences" and "composer
preferences" which I also updated, did you miss them?


Regards,
Martyn