Re: [evolution-patches] mail forward/backward search patch

[Suresh Chandrasekharan <Suresh Chandrasekharan Eng Sun COM>]

Committed to 1.4 branch.

Suresh

>nod, go for it, thanks.
>
>On Tue, 2003-10-14 at 09:40, Suresh Chandrasekharan wrote:
>
>> Thanks. So I take this as you're giving permission to put the new feature, 
>> backward search also in evolution-1-4-branch ? I won't forget the head and 
will 
>> try to create a patch whenever I get time.
>> 
>> 
>> Thanks,
>> Suresh
>> 
>> >Sorry dude, i thought i'd replied to this.
>> >
>> >I'm happy with this going in to 1.4, but it'd be nice if a new patch
>> >could be created for the 1.5 codebase, for the mailer patch, otherwise
>> >the feature becomes lost in 1.5.  As for the gtkhtml bit, someone else
>> >needs to poke their head up about that.
>> >
>> > Michael
>> >
>> >On Sat, 2003-10-11 at 05:12, Suresh Chandrasekharan wrote:
>> >
>> >> Hi,
>> >> 	Crashes are not there now. But gtkhtml expose() does not behave right 
>> >> with both the forward/backward search if for displaying the found items 
the 
>> >> gtkhtml window need be scrolled. But that applies to both forward/back 
>> searches.
>> >> 	
>> >> If you are not for providing backward search as a feature in 1.4, what 
about 
>> >> still keeping the code for backward search ( any way the existing code is 
>> buggy 
>> >> ) in htmlclueflow.c ? So in that case just ignore the patch for 
>> >> evolution/mail/mail-search.c and apply the gtkhtml one ?
>> >> 
>> >> Currently we are busy with i18n issues for 1.4, may not have time to look 
>> into 
>> >> the head if the same patch cannot be applied.
>> >> 	
>> >> Regards,
>> >> Suresh
>> >> 
>> >> >crashes, i think.  maybe its fixed in gtkhtml now?
>> >> >
>> >> >it was removed for a reason, and it wasn't afaik, multibyte (although it
>> >> >could have been?).
>> >> >
>> >> >On Fri, 2003-10-10 at 10:53, Suresh Chandrasekharan wrote:
>> >> >
>> >> >> Hi,
>> >> >> 	Do you remember what kind of instability it caused ? 
>> >> >> Thanks,
>> >> >> Suresh
>> >> >> 
>> >> >> 
>> >> >> 
>> >> >> >sorry, i formed a reply in my head but forgot to send anything ...
>> >> >> >
>> >> >> >the only thing re the mail part is that it was removed not merely
>> >> >> >because it didn't work with multibyte character sets, but because it
>> >> >> >caused instability.
>> >> >> >
>> >> >> >i'm not sure if this should be targetted for 1.4, since 'strictly', 
it's
>> >> >> >a new feature.  also note that head does the search dialogue 
differently
>> >> >> >(glade file), tho a similar patch shouldn't be too hard (you'd have to
>> >> >> >add back the functionality though).
>> >> >> >
>> >> >> >
>> >> >> >On Fri, 2003-10-10 at 07:56, Suresh Chandrasekharan wrote:
>> >> >> >
>> >> >> >> Hi All,
>> >> >> >> 	Once again pinging to see whether somebody has looked into this.
>> >> >> >> Regards,
>> >> >> >> Suresh
>> >> >> >> 
>> >> >> >> _______________________________________________
>> >> >> >> Evolution-patches mailing list
>> >> >> >> Evolution-patches lists ximian com
>> >> >> >> http://lists.ximian.com/mailman/listinfo/evolution-patches
>> >> >> 
>> >> >> Thanks & Regards,
>> >> >> Suresh
>> >> >> 
>> >> 
>> >> Thanks & Regards,
>> >> Suresh
>> >> 
>> >> _______________________________________________
>> >> Evolution-patches mailing list
>> >> Evolution-patches lists ximian com
>> >> http://lists.ximian.com/mailman/listinfo/evolution-patches
>> 
>> Thanks & Regards,
>> Suresh
>> 

Thanks & Regards,
Suresh