[evolution-patches] e-book patch, fixes crash when replying



the ChangeLog entry gives the details:

Chris
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1435.2.19
diff -u -r1.1435.2.19 ChangeLog
--- ChangeLog	21 Oct 2003 13:47:28 -0000	1.1435.2.19
+++ ChangeLog	4 Nov 2003 22:12:29 -0000
@@ -1,3 +1,13 @@
+2003-11-04  Chris Toshok  <toshok ximian com>
+
+	* backend/ebook/e-book.c (e_book_load_uri): put the URILoading
+	assignment before e_book_load_uri_from_factory, as if there's a
+	corba exception that happens and we call the user cb in _step, it
+	could (as in the default book code) unref the ebook.  really, we
+	should hold a ref to the book, but this is easier for the moment
+	and doesn't result in us leaking when i get the ref/unref code
+	wrong.
+
 2003-09-19  Gilbert Fang  <gilbert fang sun com>
 
        * addressbook/gui/component/addressbook-component.c (xfer_folder):
Index: backend/ebook/e-book.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/backend/ebook/e-book.c,v
retrieving revision 1.74.4.2
diff -u -r1.74.4.2 e-book.c
--- backend/ebook/e-book.c	15 Aug 2003 18:45:18 -0000	1.74.4.2
+++ backend/ebook/e-book.c	4 Nov 2003 22:12:29 -0000
@@ -786,9 +786,9 @@
 
 	factory = book->priv->iter->data;
 
-	e_book_load_uri_from_factory (book, factory, load_uri_data);
-
 	book->priv->load_state = URILoading;
+
+	e_book_load_uri_from_factory (book, factory, load_uri_data);
 }
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]