[evolution-patches] Re: Seeking patch review for 19965 and 43846.

[Ettore Perazzoli <ettore ximian com>]

Hi,

On Fri, 2003-11-07 at 03:40, Calvin Liu wrote:
> And Ettore, could you please review it? And if it's need to be
> improved, I'd like to do so. Thanks.

Sorry I missed this one.

A few comments on the patch:

      * You should remove the shortcut using the "removed_folder" signal
        on the EStorageSet instead of doing it in the "delete folder"
        command.  This way you can make sure that the shortcuts are
        removed whenever folders are removed, not just for that specific
        code path.

      * Compare URIs with strcmp(), not g_strcasecmp(); URIs are
        case-sensitive.

      * Use "i" and "j" instead of "loopGroup" and "loopShortcut" for
        iteration variables.

      * The spacing is also odd (both vertically and horizontally)... 
        It would be better to use the same style as the rest of the
        shell code.

-- Ettore