Re: [evolution-patches] EHLO empty-hostname-string patch

[Jeffrey Stedfast <fejj ximian com>]

On Tue, 2003-05-13 at 03:59, Not Zed wrote:
> On Tue, 2003-05-13 at 05:09, Dan Winship wrote:
> > On Mon, 2003-05-12 at 15:09, Jeffrey Stedfast wrote:
> > > Thought I fixed this a while back, but apparently never committed or
> > > something.
> > > 
> > > anyways, this fixes a case where if host lookup fails and results in
> > > host->h_name being an empty string rather than NULL (huh???), we default
> > > back to using the IP address form.
> > 
> > This should be fixed in e_gethostbyname_r, so that other pieces of code
> > don't run into the same problem. (In fact, it's probably a bug in
> > e_gethostbyname_r that's causing this anyway.)
> 
> *nod*
> 
> But the code in smtp-transport is wrong anyway,

right.

>  it should be generating
> an uninitialised variable warning (but doesn't?).

might be, but only for the broken setups I'd imagine (since normally
host->h_name would not be empty if gethostbyname returned successfully).

> 
> patch looks good jeff.

committed.

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com