Re: [evolution-patches] EHLO empty-hostname-string patch



On Tue, 2003-05-13 at 05:09, Dan Winship wrote:
> On Mon, 2003-05-12 at 15:09, Jeffrey Stedfast wrote:
> > Thought I fixed this a while back, but apparently never committed or
> > something.
> > 
> > anyways, this fixes a case where if host lookup fails and results in
> > host->h_name being an empty string rather than NULL (huh???), we default
> > back to using the IP address form.
> 
> This should be fixed in e_gethostbyname_r, so that other pieces of code
> don't run into the same problem. (In fact, it's probably a bug in
> e_gethostbyname_r that's causing this anyway.)

*nod*

But the code in smtp-transport is wrong anyway, it should be generating
an uninitialised variable warning (but doesn't?).

patch looks good jeff.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]