Re: [evolution-patches] composer fix regarding sending garbled text

[Jeffrey Stedfast <fejj ximian com>]

On Mon, 2003-06-30 at 00:36, Not Zed wrote:
> On Sat, 2003-06-28 at 04:06, Jeffrey Stedfast wrote:
> > the easiest way to demonstrate this problem is to reply to one of
> > Radek's messages...
> > 
> > the problem was that the content->rawtext was set to TRUE and the text
> > stream was in UTF-8 - so when the mime part got written out, it would
> > assume that it didn't have to do any text conversion. oops.
> 
> is this because rawtext changed to defaulting to in ?

yep

> 
> > the other way to fix this bug, of course, is to convert the text to the
> > proper charset in the build_message() function rather than setting
> > rawtext to FALSE, but this was a simpler fix so I opted for it instead.
> 
> This is probably the more correct fix anyway, with the current api.

*nod*. Should this be redone to use the charset filter approach? or
should this patch be committed as-is?

> 
> You did notice that the html is set to charset=utf-8 anyway ...

yea, I did... but for consistancy I figured I'd set the bit anyway.

> 
> But yeah the fix looks right
> 
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com