[evolution-patches] composer fix regarding sending garbled text



the easiest way to demonstrate this problem is to reply to one of
Radek's messages...

the problem was that the content->rawtext was set to TRUE and the text
stream was in UTF-8 - so when the mime part got written out, it would
assume that it didn't have to do any text conversion. oops.

the other way to fix this bug, of course, is to convert the text to the
proper charset in the build_message() function rather than setting
rawtext to FALSE, but this was a simpler fix so I opted for it instead.

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com
? 43241.patch
? 44065.patch
? fix.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
retrieving revision 1.544
diff -u -r1.544 ChangeLog
--- ChangeLog	19 Jun 2003 16:59:02 -0000	1.544
+++ ChangeLog	27 Jun 2003 18:15:01 -0000
@@ -1,3 +1,8 @@
+2003-06-27  Jeffrey Stedfast  <fejj ximian com>
+
+	* e-msg-composer.c (build_message): Set the rawtext bits for the
+	'plain' and 'html' data wrappers to FALSE.
+
 2003-06-19  Larry Ewing  <lewing ximian com>
 
 	* listener.c (insert_paragraph_after): free the return value.
Index: e-msg-composer.c
===================================================================
RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
retrieving revision 1.395
diff -u -r1.395 e-msg-composer.c
--- e-msg-composer.c	18 Jun 2003 17:57:01 -0000	1.395
+++ e-msg-composer.c	27 Jun 2003 18:15:02 -0000
@@ -402,6 +402,8 @@
 	}
 	
 	plain = camel_data_wrapper_new ();
+	plain->rawtext = FALSE;
+	
 	stream = camel_stream_mem_new_with_byte_array (data);
 	camel_data_wrapper_construct_from_stream (plain, stream);
 	camel_object_unref (stream);
@@ -428,7 +430,10 @@
 			camel_object_unref (plain);
 			return NULL;
 		}
+		
 		html = camel_data_wrapper_new ();
+		html->rawtext = FALSE;
+		
 		stream = camel_stream_mem_new_with_byte_array (data);
 		camel_data_wrapper_construct_from_stream (html, stream);
 		camel_object_unref (stream);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]