Re: [evolution-patches] [calendar, keynav] seek review for bug 45328 (Alt+PageUp/PageDown, go to the first/last day in current month)



Rodrigo Moya wrote:
 	GNOME_CAL_MONTH_VIEW
 } GnomeCalendarViewType;
 
+typedef enum
+{
+  GNOME_CAL_GOTO_TODAY,
+  GNOME_CAL_GOTO_DATE,
+  GNOME_CAL_GOTO_FIRST_DAY_OF_MONTH,
+  GNOME_CAL_GOTO_LAST_DAY_OF_MONTH,
+  GNOME_CAL_GOTO_FIRST_DAY_OF_WEEK,
+  GNOME_CAL_GOTO_LAST_DAY_OF_WEEK,
+} GNOME_CAL_GOTO_DATE_TYPE;
+

    
please don't use capital letters for types. The GNOME convention is to
use studly caps, so that should be GnomeCalendarGotoDateType. (Note it
should also be Calendar, not Cal, since the type is GnomeCalendar).

  
Oh, Yes, My fault. I should follow that. There is a good example above.  What about the other part of the patch?
Do I need to make a new one? Or I can commit it with that name changed?

Thanks,
Bolian



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]