Re: [evolution-patches] [calendar, keynav] seek review for bug 45328 (Alt+PageUp/PageDown, go to the first/last day in current month)

[Rodrigo Moya <rodrigo ximian com>]

On Mon, 2003-06-30 at 09:51, Bolian Yin wrote:
> Hi JP and Rodrigo,
> 
> Patch review again.  Thanks.
> Bug # 45328, http://bugzilla.ximian.com/show_bug.cgi?id=45328
> (Alt+PageUp/PageDown, go to the first/last day in current month in dayview)
> 
> This patch did more the bug summary. Alt+Home/End, Alt+PageUp/PageDown 
> all works in both dayview and weekview.

> Index: gui/gnome-cal.h
> ===================================================================
> RCS file: /home/localcvs/src/evolution/calendar/gui/gnome-cal.h,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- gui/gnome-cal.h	24 Jun 2003 05:49:07 -0000	1.1
> +++ gui/gnome-cal.h	30 Jun 2003 04:52:41 -0000	1.2
> @@ -57,6 +57,16 @@
>  	GNOME_CAL_MONTH_VIEW
>  } GnomeCalendarViewType;
>  
> +typedef enum
> +{
> +  GNOME_CAL_GOTO_TODAY,
> +  GNOME_CAL_GOTO_DATE,
> +  GNOME_CAL_GOTO_FIRST_DAY_OF_MONTH,
> +  GNOME_CAL_GOTO_LAST_DAY_OF_MONTH,
> +  GNOME_CAL_GOTO_FIRST_DAY_OF_WEEK,
> +  GNOME_CAL_GOTO_LAST_DAY_OF_WEEK,
> +} GNOME_CAL_GOTO_DATE_TYPE;
> +
>
please don't use capital letters for types. The GNOME convention is to
use studly caps, so that should be GnomeCalendarGotoDateType. (Note it
should also be Calendar, not Cal, since the type is GnomeCalendar).

cheers