Re: [evolution-patches] spell prefs in evo/mail

[Jeffrey Stedfast <fejj ximian com>]

sure, this looks ok I guess.

Jeff

On Wed, 2003-06-25 at 12:39, Radek DoulĂ­k wrote:
> I have reverted this patch and I am attaching simpler one which only
> fixes spell error color bug and doesn't move the gconf keys. I will look
> more into moving after 1.4.1 release is done.
> 
> Cheers
> Radek
> 
> On Wed, 2003-06-25 at 10:41, Radek DoulÄ­k wrote:
> > On Wed, 2003-06-25 at 04:22, Not Zed wrote:
> > > Sigh, you didn't give me time to disagree with this patch.
> > 
> > I am sorry, I though approval from Jeff was enough.
> > 
> > > I have serious issues with this:
> > >  
> > > +    <schema>
> > > +     
> > > <key>/schemas/apps/evolution/mail/composer/spell_copied_from_old_location</key>
> > > +     
> > > <applyto>/apps/evolution/mail/composer/spell_copied_from_old_location</applyto>
> > > +      <owner>evolution-mail</owner>
> > > +      <type>bool</type>
> > > +      <default>false</default>
> > > +      <locale name="C">
> > > +         <short>spell preferences are copied from an old
> > > location</short>
> > > +         <long>
> > > +        spell preferences are copied from an old location
> > > (/GNOME/Spell)
> > > +         </long>
> > > +      </locale>
> > > +    </schema>
> > > 
> > > 
> > > All I can say is, WTF?  What sort of nonsense is this ???  The config
> > > data is already versioned, and besides that, you can easily discover it
> > > has been copied by implicit reasoning (i.e. if the new location exists
> > > ... its been copied).
> > 
> > The reason for that change was to have default for spell error color in
> > gconf. AFAIK I can't tell if value from gconf is schema default or
> > actual value. The other benefit is avoiding additional gconf round-trips
> > for /GNOME/Spell directory. That's why I did it like this.
> > 
> > What do you dislike on that approach so much? The visibility of copied
> > flag in gconf-editor?
> > 
> > > Might be a nice idea to clean up the GET macro stuff too.
> > 
> > I will use the G_STMT_START/G_STMT_END macros if that's what you mean
> > and/or rename it.
> > 
> > Radek
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com