Re: [evolution-patches] spell prefs in evo/mail

[Not Zed <notzed ximian com>]

Sigh, you didn't give me time to disagree with this patch.

I have serious issues with this:
 
+    <schema>
+     
<key>/schemas/apps/evolution/mail/composer/spell_copied_from_old_location</key>
+     
<applyto>/apps/evolution/mail/composer/spell_copied_from_old_location</applyto>
+      <owner>evolution-mail</owner>
+      <type>bool</type>
+      <default>false</default>
+      <locale name="C">
+         <short>spell preferences are copied from an old
location</short>
+         <long>
+        spell preferences are copied from an old location
(/GNOME/Spell)
+         </long>
+      </locale>
+    </schema>


All I can say is, WTF?  What sort of nonsense is this ???  The config
data is already versioned, and besides that, you can easily discover it
has been copied by implicit reasoning (i.e. if the new location exists
... its been copied).

If this needs a config upgrade, which i'm not sure it does, it would go
in shell/e-config-upgrade, and bump evolution's config version.  But
since its not strictly an upgrade, it could probably just be a "get
value, if not there, get a default from gnome spell setting", if gconf's
brainded api will let you do that anyway.

Might be a nice idea to clean up the GET macro stuff too.

On Wed, 2003-06-25 at 00:43, Radek Doulík wrote:
> attached patch adds default spell error color to schema file and moves
> spell preferences from /GNOME/Spell to /apps/evolution/mail/composer
> (gconf location).
>